Bug 466660
| Summary: | Review Request: sympy - A Python library for symbolic mathematics | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Conrad Meyer <cse.cem+redhatbugz> |
| Component: | Package Review | Assignee: | Gwyn Ciesla <gwync> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, gwync, notting, susi.lehtola |
| Target Milestone: | --- | Flags: | gwync:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-10-15 23:28:31 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Conrad Meyer
2008-10-12 11:17:41 UTC
Builds in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=875246 Starting full review. . . . rpmlint on SRPM is clean rpmlint on RPMs: sympy.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/sympy/utilities/compilef.py 0644 This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. sympy.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/sympy/solvers/numeric.py 0644 This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. sympy.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/sympy/mpmath/elliptic.py 0644 This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. sympy.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/sympy/mpmath/tests/test_elliptic.py 0644 This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. Since these aren't meant to be executable, it would be good to patch out the shebangs and send the patch upstream. Otherwise, full review looks great. Patch submitted upstream: http://code.google.com/p/sympy/issues/detail?id=1156 New spec and SRPM URLs: http://konradm.fedorapeople.org/fedora/SPECS/sympy.spec http://konradm.fedorapeople.org/fedora/SRPMS/sympy-0.6.2-2.fc9.src.rpm rpmlint on the spec, src.rpm, and generated rpm [0] is clean. [0]: http://konradm.fedorapeople.org/fedora/RPMS/noarch/sympy-0.6.2-2.fc9.noarch.rpm Alright, there we go. Looks good. APPROVED. New Package CVS Request ======================= Package Name: sympy Short Description: A Python library for symbolic mathematics Owners: konradm Branches: F-9 F-10 InitialCC: cvs done Built in rawhide. Thanks for the review! Please add also branch for EPEL (at least 5), and build documentation into a -doc package. HTML documentation builds fine, LaTeX doesn't seem to work. Package Change Request ====================== Package Name: sympy New Branches: EL-5 Owners: konradm Wait, no, I don't want to maintain this for EPEL. You can take it if you like. Fine. Package Change Request ====================== Package Name: sympy New Branches: EL-5 Owners: jussilehtola cvs done. |