Bug 466688
| Summary: | Review Request: mpfi - An interval arithmetic library based on MPFR | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Conrad Meyer <cse.cem+redhatbugz> | ||||||
| Component: | Package Review | Assignee: | Patrice Dumas <pertusus> | ||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | fedora-package-review, notting, pertusus, rc040203 | ||||||
| Target Milestone: | --- | Flags: | pertusus:
fedora-review+
kevin: fedora-cvs+ |
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2008-10-23 23:25:59 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Conrad Meyer
2008-10-12 20:27:47 UTC
MUSTFIX: - Package's NEVR doesn't comply to https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Non-Numeric_Version_in_Release - Package doesn't install *info's correctly. Something similar to this is missing: Requires(post): /sbin/install-info Requires(pre): /sbin/install-info %post /sbin/install-info \ --info-dir=/usr/share/info /usr/share/info/mpfi.info.gz || : %preun: if [ $1 = 0 ]; then /sbin/install-info --delete \ --info-dir=/usr/share/info /usr/share/info/mpfi.info.gz || : fi - Package split: Provided this package doesn't provide any run-time usable library or applications, and contains devel-docs only, the "mpfi base package" doesn't make sense, IMO. My recommendation: Move the info file to *-devel and don't ship a base package. CONSIDER: I am not sure if shipping this package makes much sense, because browsing their site indicates this project might be pretty much dead (Take into account, you are building from a 2.5 years old "release candidate" tarball). I will fix these things this evening when I get time. As to upstream being dead: this library is a module of the SAGE project, and so it is still helpful to include in Fedora. New spec and SRPM: http://konradm.fedorapeople.org/fedora/SPECS/mpfi.spec http://konradm.fedorapeople.org/fedora/SRPMS/mpfi-1.3.4-0.1.RC3.fc9.src.rpm I am not sure how to not ship a base package. There are no files in [0] but it's still created. [0]: http://konradm.fedorapeople.org/fedora/RPMS/x86_64/mpfi-1.3.4-0.1.RC3.fc9.x86_64.rpm (In reply to comment #4) > I am not sure how to not ship a base package. Simply remove the "%files" corresponding to the base package. (In reply to comment #1) > Requires(pre): /sbin/install-info This should have been Requires(preun): /sbin/install-info Sorry for that. New spec/SRPM: http://konradm.fedorapeople.org/fedora/SPECS/mpfi.spec http://konradm.fedorapeople.org/fedora/SRPMS/mpfi-1.3.4-0.2.RC3.fc9.src.rpm Still major issues:
- %preun/%post need to be moved to the *-devel subpackage.
- The rules in %preun/%post should refer to /usr/share/info using %{_infodir} instead of using hard-coded values.
- The *devel package
Requires: %{name} = %{version}-%{release}
which doesn't exit.
One minor cosmetic issue:
- The START-INFO-DIR-ENTRY in mpfr.texi references mpfi.info.
This causes an ugly reference to mpfi.info in /usr/share/info/dir.
I am going to attach patches to address all of these issues.
Created attachment 320284 [details]
patch to address spec file issues
Created attachment 320285 [details]
patch to address INFO-DIR-ENTRY issue
Thanks for the patches; new urls: http://konradm.fedorapeople.org/fedora/SPECS/mpfi.spec http://konradm.fedorapeople.org/fedora/SRPMS/mpfi-1.3.4-0.3.RC3.fc9.src.rpm I'd suggest dropping COPYING since it is the GPL and not the LGPL.
Also the README is useless in my opinion.
using
make install DESTDIR=$RPM_BUILD_ROOT INSTALL='install -p'
may keep timestamps of include files.
install-info knows automatically how to deal with compression, please
remove the .gz from install-info invocations.
I would also suggest using
%{_infodir}/%{name}.info*
to catch different compression or no compression.
New URLs: http://konradm.fedorapeople.org/fedora/SPECS/mpfi.spec http://konradm.fedorapeople.org/fedora/SRPMS/mpfi-1.3.4-0.4.RC3.fc9.src.rpm * rpmlint is silent * free software, upstream includes wrong license, so license file not shipped * match upstream 02f3fb7a09ef683f035dd20dca653507 mpfi-1.3.4-RC3.tar.gz * follow packaging guidelines * static library rightly packaged * %files section right please keep the timestamp of archives (with spectool -g or wget -N for example): -rw-rw-r-- 1 dumas dumas 150760 oct. 20 21:48 mpfi-1.3.4-RC3.tar.gz -rw-r--r-- 1 dumas dumas 150760 oct. 12 21:11 ../SOURCES/mpfi-1.3.4-RC3.tar.gz If source timestamp is kept APPROVED You should contact upstream about the license file mismatch. Also wait something like a day to let Ralf comment if he wants to. wget -N says 'Last-modified header missing -- time-stamps turned off.' I will contact upstream about this. Indeed, I didn't noticed, but my download was indeed newer than yours!! So definitely APPROVED. New Package CVS Request ======================= Package Name: mpfi Short Description: An interval arithmetic library based on MPFR Owners: konradm Branches: F-10 F-9 InitialCC: cvs done. Built in rawhide, closing. |