This service will be undergoing maintenance at 00:00 UTC, 2016-08-01. It is expected to last about 1 hours

Bug 467001

Summary: Review Request: litmus - WebDAV Test Suite
Product: [Fedora] Fedora Reporter: John Anderson <john.e.anderson>
Component: Package ReviewAssignee: Paulo Roma Cavalcanti <promac>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting, promac
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-12-23 06:43:44 EST Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Bug Depends On:    
Bug Blocks: 201449    

Description John Anderson 2008-10-14 21:51:16 EDT
Spec URL: http://transfer.eragen.com/rpm/litmus.spec
SRPM URL: http://transfer.eragen.com/rpm/litmus-0.12-1.fc9.src.rpm

Description: litmus is a WebDAV server test suite, which aims to test whether a server is compliant with the WebDAV protocol as specified in RFC2518
Comment 1 Jon Ciesla 2008-10-21 10:37:06 EDT
*** Bug 467856 has been marked as a duplicate of this bug. ***
Comment 2 Paulo Roma Cavalcanti 2008-10-22 16:25:16 EDT
Should enable ssl support, because many webdav servers
use the https protocol.

%configure --with-ssl

Also, should add BR openssl-devel.

Please, see bug 467856. It has a simpler spec.
Comment 3 John Anderson 2008-10-22 16:44:33 EDT
Updated with SSL:

http://transfer.eragen.com/rpm/litmus.spec
http://transfer.eragen.com/rpm/litmus-0.12-1.fc9.src.rpm

As far as the simpler spec in bug 467856, it looks like even though he included neon-devel, it was still building against neon included in the source.

My patch and other changes are specifically to get it to build against the distro supplied neon.
Comment 4 Paulo Roma Cavalcanti 2008-10-23 04:31:53 EDT
(In reply to comment #3)
> Updated with SSL:
> 
> http://transfer.eragen.com/rpm/litmus.spec
> http://transfer.eragen.com/rpm/litmus-0.12-1.fc9.src.rpm
> 
> As far as the simpler spec in bug 467856, it looks like even though he included
> neon-devel, it was still building against neon included in the source.
> 
> My patch and other changes are specifically to get it to build against the
> distro supplied neon.

[cascavel:~/redhat/SOURCES/litmus-0.12] configure --help | grep neon
  --with-included-neon    force use of included neon library
  --with-neon[=DIR]       specify location of neon library

It seems to me that the default is using an external neon ...

configure --with-ssl=openssl

....

configure: Configured to build litmus 0.12:

  Install prefix:  /usr/local
  Compiler:        gcc
  neon library:    library in /usr (0.27.2)
  XML parser:      using whatever neon uses
  SSL library:     SSL is supported by neon


Everything was detected correctly, on F8, without any patch.
But ssl is not necessary, since neon provides it.

make

......

gcc  -o basic src/basic.o -L. -ltest -lneon  
gcc -DHAVE_CONFIG_H  -I. -I./lib -I./src -I./test-common -g -O2 -I/usr/include/neon -c src/copymove.c -o src/copymove.o
gcc  -o copymove src/copymove.o -L. -ltest -lneon  
gcc -DHAVE_CONFIG_H  -I. -I./lib -I./src -I./test-common -g -O2 -I/usr/include/neon -c src/props.c -o src/props.o
gcc  -o props src/props.o -L. -ltest -lneon  
gcc -DHAVE_CONFIG_H  -I. -I./lib -I./src -I./test-common -g -O2 -I/usr/include/neon -c src/locks.c -o src/locks.o
gcc  -o locks src/locks.o -L. -ltest -lneon  
gcc -DHAVE_CONFIG_H  -I. -I./lib -I./src -I./test-common -g -O2 -I/usr/include/neon -c src/http.c -o src/http.o
gcc  -o http src/http.o -L. -ltest -lneon  

  Now run:

     make URL=http://dav.server/path/ check
 or  make URL=http://dav.server/path/ CREDS="uname passwd" check
Comment 5 John Anderson 2008-10-23 09:20:34 EDT
My mistake, you're right. Removed patch.

http://transfer.eragen.com/rpm/litmus.spec
http://transfer.eragen.com/rpm/litmus-0.12-3.fc9.src.rpm
Comment 6 Paulo Roma Cavalcanti 2008-11-01 05:55:55 EDT
Hi,

your comments in changelog for versions
0.12-1 and 1.12-2 are the same.

Also, I think that 

BuildRequires:  autoconf automake

is not necessary. Authough there is an autogen.sh in the source,
it is not used.

I tried building litmus with these options

%configure --with-ssl \
           --with-expat \
           --with-included-neon \
           --enable-threadsafe-ssl=posix

and

BuildRequires: expat-devel
BuildRequires: neon-devel
BuildRequires: openssl-devel

and got

  Install prefix:  /usr
  Compiler:        gcc
  neon library:    included libneon (0.28.3)
  XML parser:      expat
  SSL library:     SSL support enabled, using OpenSSL (0.9.7 or later)

Therefore, the bundled neon version is 0.28.3 (the same of F9),
but higher than F8 (0.27.2). It also uses the external expat in this case.
As a consequence, building for F8 is better this way, if you intend to do that.

But this is just a suggestion, because using the bundled neon, seems also to 
force the use of the external expat and openssl. Otherwise, it uses whatever
neon uses.
Comment 7 John Anderson 2008-12-09 14:26:04 EST
Adjusted the configure and removed autoconf, automake

http://transfer.eragen.com/rpm/litmus.spec
http://transfer.eragen.com/rpm/litmus-0.12-4.fc10.src.rpm
Comment 8 Paulo Roma Cavalcanti 2008-12-18 20:30:53 EST
Hi,

--with-expat is pointless without 
--with-included-neon, because it will
use whatever neon uses:

configure: Configured to build litmus 0.12:
  Install prefix:  /usr
  Compiler:        gcc
  neon library:    library in /usr (0.28.3)
  XML parser:      using whatever neon uses
  SSL library:     SSL is supported by neon

Therefore, you have to choose, either use external neon
or external ssl and expat.

Also, you can use a %bcond_without exernal_neon,
and choose the configuration options based on this.

Finally, the link with the .src.rpm for F10 is dead.
Comment 9 Paulo Roma Cavalcanti 2010-12-23 06:43:44 EST
I am closing this review request because it is stalled for two years now.