Bug 467257

Summary: Wrong argument of livecd-iso-to-disk --overlay-size-mb causes USB filesystem corruption
Product: [Fedora] Fedora Reporter: Jacek Chrząszcz <chrzaszc>
Component: livecd-toolsAssignee: Jeremy Katz <katzj>
Status: CLOSED UPSTREAM QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: 9CC: davidz, katzj
Target Milestone: ---   
Target Release: ---   
Hardware: i386   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-10-21 15:25:21 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jacek Chrząszcz 2008-10-16 15:34:08 UTC
Description of problem:

When the parameter of --overlay-size-mb is incorrect (e.g. 256MB instead of 256) the script doesn't stop but an arbitrary (large?) overlay size is used and the filesystem on USB stick (vfat) is garbled.

Version-Release number of selected component (if applicable):
livecd-tools-017.1-1.fc9.i386

How reproducible:
I tried only once, but it should be deterministic.

Steps to Reproduce:
1. connect a vfat USB stick
2. run livecd-iso-to-disk --overlay-size-mb 256MB /tmp/F10-Beta-i686-Live-KDE.iso /dev/sdb1
  
Actual results:
The script prints the message that the argument is incorrect, but continues anyway. After some time it stops with "cannot write some file" sort of message, the filesystem on the USB stick is garbled

Expected results:
The script should stop with the message that the argument is incorrect.

Comment 1 Jeremy Katz 2008-10-21 15:25:21 UTC
Fixed in git; thanks for the report