Bug 467322 (mingw32-bzip2)

Spec URL: http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/file/tip/bzip2/mingw32-bzip2.spec
SRPM URL: http://www.annexia.org/tmp/mingw/fedora-10/src/SRPMS/mingw32-bzip2-1.0.5-4.fc10.src.rpm

All looks OK, I just have a query about including the license file. I understand not including man/info pages but I believe there's still a requirement to include a license? I couldn't see anything in the mingw packaging docs that would exclude it.

+ rpmlint output

$ rpmlint -i mingw32-bzip2-1.0.5-4.fc10.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ package name satisfies the packaging naming guidelines
+ specfile name matches the package base name
+ package should satisfy packaging guidelines
+ license meets guidelines and is acceptable to Fedora
+ license matches the actual package license

? %doc includes license file
+ spec file written in American English
+ spec file is legible
+ upstream sources match sources in the srpm
  3c15a0c8d1d3ee1c46a1634d00617b1a  bzip2-1.0.5.tar.gz
+ package successfully builds on at least one architecture
  tested using koji on rawhide
+ BuildRequires list all build dependencies
n/a %find_lang instead of %{_datadir}/locale/*
n/a binary RPM with shared library files must call ldconfig in %post and %postun
+ does not use Prefix: /usr
n/a package owns all directories it creates
n/a no duplicate files in %files
+ %defattr line
+ %clean contains rm -rf $RPM_BUILD_ROOT
+ consistent use of macros
+ package must contain code or permissible content
n/a large documentation files should go in -doc subpackage
+ files marked %doc should not affect package
n/a header files should be in -devel
n/a static libraries should be in -static
n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a libfoo.so must go in -devel
n/a devel must require the fully versioned base
+ packages should not contain libtool .la files
n/a packages containing GUI apps must include %{name}.desktop file
+ packages must not own files or directories owned by other packages
+ %install must start with rm -rf %{buildroot} etc.
+ filenames must be valid UTF-8

Optional:

+ if there is no license file, packager should query upstream
n/a translations of description and summary for non-English languages, if
available
+ reviewer should build the package in mock/koji
n/a the package should build into binary RPMs on all supported architectures
n/a review should test the package functions as described
+ scriptlets should be sane
n/a pkgconfig files should go in -devel
+ shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or
/usr/sbin

Thanks for looking at this.  This updated version just adds
the LICENSE file to the %doc section.

Spec URL: http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/file/tip/bzip2/mingw32-bzip2.spec
SRPM URL: http://www.annexia.org/tmp/mingw/fedora-10/src/SRPMS/mingw32-bzip2-1.0.5-5.fc10.src.rpm

* Thu Dec 18 2008 Richard Jones <rjones> - 1.0.5-5
- Include the LICENSE file in doc section.

APPROVED!

Thanks. Not sure if the license file will affect any of the other packages but its on your list now.

New Package CVS Request
=======================
Package Name: mingw32-bzip2
Short Description: MinGW port of bzip2 file compression utility
Owners: rjones berrange lfarkas
Branches: EL-5 F-10
InitialCC:

cvs done.

Thanks Peter and Kevin.

Imported and built.

I think this is in rawhide, OK to close?

Closed - sorry I forgot to do this before :-)