Bug 467329 (mingw32-termcap)
| Summary: | Review Request: mingw32-termcap - MinGW terminal feature database | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Richard W.M. Jones <rjones> |
| Component: | Package Review | Assignee: | Peter Robinson <pbrobinson> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | berrange, bruno, fedora-package-review, notting, pbrobinson |
| Target Milestone: | --- | Flags: | pbrobinson:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-12-21 11:32:07 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 454410 | ||
| Bug Blocks: | 467398, 467399 | ||
|
Description
Richard W.M. Jones
2008-10-16 20:52:17 UTC
Note that there is no native version of this package (it was dropped in Fedora 9 era). However we need it because there is no termcap in the Win32 API. Also note the license really is GPL. Spec URL: http://hg.et.redhat.com/misc/fedora-mingw--devel/?cmd=manifest;manifest=06642864def98e59c07661b91e0b58d0b1b25723;path=/termcap/ SRPM URL: http://www.annexia.org/tmp/mingw/fedora-9/src/SRPMS/mingw32-termcap-1.3.1-3.fc9.src.rpm All free Unices abandoned termcap in favour of ncurses between 1992 and 1995. Reason: tgetent() is inherently unsafe to use, it is designed to produce buffer overflows, because the caller of this function and the implementation of this function simply don't communicate about the size of the buffer. It'd best to ditch this package, and use ncurses instead. Ncurses doesn't compile on Windows, although if you do manage to patch it and get a working ncurses, please post it because that would be a very important advance for us. Spec URL: http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/file/tip/termcap/mingw32-termcap.spec SRPM URL: http://www.annexia.org/tmp/mingw/fedora-10/src/SRPMS/mingw32-termcap-1.3.1-4.fc10.src.rpm The same issue with the license
+ rpmlint output
rpmlint -i mingw32-termcap-1.3.1-4.fc10.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
+ package name satisfies the packaging naming guidelines
+ specfile name matches the package base name
+ package should satisfy packaging guidelines
+ license meets guidelines and is acceptable to Fedora
+ license matches the actual package license
- %doc includes license file
license file not included in rpm
+ spec file written in American English
+ spec file is legible
+ upstream sources match sources in the srpm
ffe6f86e63a3a29fa53ac645faaabdfa termcap-1.3.1.tar.gz
+ package successfully builds on at least one architecture
tested using koji scratch build
+ BuildRequires list all build dependencies
n/a %find_lang instead of %{_datadir}/locale/*
n/a binary RPM with shared library files must call ldconfig in %post and %postun+ does not use Prefix: /usr
n/a package owns all directories it creates
n/a no duplicate files in %files
+ %defattr line
+ %clean contains rm -rf $RPM_BUILD_ROOT
+ consistent use of macros
+ package must contain code or permissible content
n/a large documentation files should go in -doc subpackage
+ files marked %doc should not affect package
n/a header files should be in -devel
n/a static libraries should be in -static
n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a libfoo.so must go in -devel
n/a devel must require the fully versioned base
+ packages should not contain libtool .la files
n/a packages containing GUI apps must include %{name}.desktop file
+ packages must not own files or directories owned by other packages
+ %install must start with rm -rf %{buildroot} etc.
+ filenames must be valid UTF-8
Optional:
+ if there is no license file, packager should query upstream
n/a translations of description and summary for non-English languages, if
available
+ reviewer should build the package in mock/koji
n/a the package should build into binary RPMs on all supported architectures
n/a review should test the package functions as described
+ scriptlets should be sane
n/a pkgconfig files should go in -devel
+ shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or
/usr/sbin
Spec URL: http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/file/tip/termcap/mingw32-termcap.spec SRPM URL: http://www.annexia.org/tmp/mingw/fedora-10/src/SRPMS/mingw32-termcap-1.3.1-5.fc10.src.rpm * Fri Dec 19 2008 Richard W.M. Jones <rjones> - 1.3.1-5 - Added license file to doc section. APPROVED! New Package CVS Request ======================= Package Name: mingw32-termcap Short Description: MinGW terminal feature database Owners: rjones berrange lfarkas Branches: EL-5 F-10 InitialCC: cvs done. Thanks Peter and Kevin. Imported and built. |