Bug 467399 (mingw32-readline)
| Summary: | Review Request: mingw32-readline - MinGW port of readline for editing typed command lines | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Richard W.M. Jones <rjones> |
| Component: | Package Review | Assignee: | Tim Lauridsen <tim.lauridsen> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | berrange, fedora-package-review, notting, tim.lauridsen |
| Target Milestone: | --- | Flags: | tim.lauridsen:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-01-21 21:33:54 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 454410, 467329 | ||
| Bug Blocks: | 467407, 467418, 491758 | ||
|
Description
Richard W.M. Jones
2008-10-17 10:34:41 UTC
Spec URL: http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/file/tip/readline/mingw32-readline.spec SRPM URL: http://www.annexia.org/tmp/mingw/fedora-10/src/SRPMS/mingw32-readline-5.2-4.fc10.src.rpm * Sat Nov 22 2008 Richard W.M. Jones <rjones> - 5.2-4 - Rename *.dll.a to lib*.dll.a so that libtool can use these libraries. * Wed Nov 19 2008 Richard W.M. Jones <rjones> - 5.2-3 - Fix paths to mandir, infodir. * Fri Oct 31 2008 Richard W.M. Jones <rjones> - 5.2-2 - Rebuild against latest termcap. I will take this one $ rpmlint Download/mingw32-readline-5.2-4.fc10.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint rpmbuild/RPMS/noarch/mingw32-readline-5.2-4.fc10.noarch.rpm mingw32-readline.noarch: W: no-documentation mingw32-readline.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/readline/keymaps.h mingw32-readline.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/lib/libhistory.dll.a mingw32-readline.noarch: W: spurious-executable-perm /usr/i686-pc-mingw32/sys-root/mingw/lib/libhistory.dll.a mingw32-readline.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/readline/rlconf.h mingw32-readline.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/readline/tilde.h mingw32-readline.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/readline/rlstdc.h mingw32-readline.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/readline/history.h mingw32-readline.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/readline/rltypedefs.h mingw32-readline.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/readline/chardefs.h mingw32-readline.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/readline/readline.h mingw32-readline.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/lib/libreadline.dll.a mingw32-readline.noarch: W: spurious-executable-perm /usr/i686-pc-mingw32/sys-root/mingw/lib/libreadline.dll.a mingw32-readline.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-pc-mingw32/sys-root/mingw/lib/libreadline.dll.a mingw32-readline.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-pc-mingw32/sys-root/mingw/lib/libhistory.dll.a mingw32-readline.noarch: W: non-standard-dir-in-usr i686-pc-mingw32 Should be ok, because of the cross compiler nature of the package MUST:
* package must match the upstream source
e39331f32ad14009b9ff49cc10c5e751 readline-5.2.tar.gz (SRPM)
e39331f32ad14009b9ff49cc10c5e751 readline-5.2.tar.gz (upstream)
* package is named appropriately
mingw32-*
* it is legal for Fedora to distribute this
* license field matches the actual license.
* license is open source-compatible.
* specfile name matches %{name}
* summary and description fine
* correct buildroot
* %{?dist} is used
* no license text included in package
* package meets FHS (http://www.pathname.com/fhs/)
* changelog format fine
* Packager, Vendor ,Distribution tag not used
* License used and not Copyright
* Summary tag does not end in a period
* specfile is legible
* package successfully compiles and builds on at least x86
* make sure lines are <= 80 characters
* specfile written in American English
* no -doc sub-package necessary
* /sbin/ldconfig used in packages containing libraries.
no native libs
* GUI app, has .desktop file and uses desktop-file-install to install it.
not a gui app
* header files goes into -devel sub-package.
no native header files
* *.so goes into -devel sub-package.
no *.so files
* macros used appropriately and consistently
* no %makeinstall
* install section must begin with rm -rf $RPM_BUILD_ROOT or %{buildroot}
* The spec file handles locales properly (%find_lang )
no locales
* split Requires(pre,post) into two separate lines
* package not relocatable
* package contains code
* package owns all directories and files
* no %files duplicates
* %defattrs present
* %clean present
* %doc files do not affect runtime
* packages is following the MinGW guidelines (http://fedoraproject.org/wiki/Packaging/MinGW)
APPROVED
New Package CVS Request ======================= Package Name: mingw32-readline Short Description: MinGW port of readline for editing typed command lines Owners: rjones berrange lfarkas Branches: EL-5 F-10 InitialCC: cvs done. mingw32-readline-5.2-4.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/mingw32-readline-5.2-4.fc10 mingw32-readline-5.2-4.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |