Bug 467428 (CVE-2008-3074)

Summary: CVE-2008-3074 Vim tar.vim plugin: improper Implementation of shellescape() (arbitrary code execution)
Product: [Other] Security Response Reporter: Jan Lieskovsky <jlieskov>
Component: vulnerabilityAssignee: Red Hat Product Security <security-response-team>
Status: CLOSED ERRATA QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: unspecifiedCC: karsten, kreilly, psplicha
Target Milestone: ---Keywords: Security
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-01-09 08:35:55 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 467449, 467450    
Bug Blocks:    

Description Jan Lieskovsky 2008-10-17 13:00:54 UTC
Description of problem:

Jan Minar has reported the following problem present in Vim shellescape()
function implementation and demonstrated by testcases in tar.vim plugin:

The implementation of the shellescape() function does not properly
escape all special items, in particular the '!' character). This
can result in untrusted data being insufficiently sanitized
and possibly lead to arbitrary code execution.

To show this vulnerability can be exploited, the tar.vim plugin test cases
has been updated (tarplugin, tarplugin.v2 and tarplugin.updated test cases).

CVE-2008-3074 has been pre-assigned and used in rPath advisory:

http://www.openwall.com/lists/oss-security/2008/07/10/7

References:

http://www.rdancer.org/vulnerablevim-shellescape.html
http://www.openwall.com/lists/oss-security/2008/07/15/2
http://www.openwall.com/lists/oss-security/2008/07/10/7
http://www.rdancer.org/vulnerablevim.html
http://www.openwall.com/lists/oss-security/2008/07/13/1
http://www.openwall.com/lists/oss-security/2008/08/01/1

Comment 1 Jan Lieskovsky 2008-10-17 13:04:04 UTC
This issue affects does not affect the versions of Vim package, as shipped
with Red Hat Enterprise Linux 2.1, 3 and 4. 

This issue affects the versions of the Vim package, as shipped with Red
Hat Enterprise Linux 5 and Fedora releases 8 and 9 (only Vim 7.0 and 7.1
affected).

This issue does not affect the version of the Vim package, as shipped
in Fedora rawhide release (already fixed in Vim 7.2).

Comment 5 Red Hat Product Security 2009-01-09 08:35:55 UTC
This issue was addressed in:

Red Hat Enterprise Linux:
  http://rhn.redhat.com/errata/RHSA-2008-0580.html

Fedora (updated to upstream 7.2.060): 
  https://admin.fedoraproject.org/updates/F9/FEDORA-2008-10587
  https://admin.fedoraproject.org/updates/F10/FEDORA-2008-10644

Comment 6 Jan Lieskovsky 2009-02-24 10:34:32 UTC
Common Vulnerabilities and Exposures assigned an identifier CVE-2008-3074 to
the following vulnerability:

The shellescape function in Vim 7.0 through 7.2, including 7.2a.10,
allows user-assisted attackers to execute arbitrary code via the "!"
(exclamation point) shell metacharacter in (1) the filename of a tar
archive and possibly (2) the filename of the first file in a tar
archive, which is not properly handled by the VIM TAR plugin (tar.vim)
v.10 through v.22, as demonstrated by the shellescape, tarplugin.v2,
tarplugin, and tarplugin.updated test cases. NOTE: this issue
reportedly exists because of an incomplete fix for CVE-2008-2712.
NOTE: this issue has the same root cause as CVE-2008-3075. NOTE: due
to the complexity of the associated disclosures and the incomplete
information related to them, there may be inaccuracies in this CVE
description and in external mappings to this identifier.

References:
http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2008-3074
http://marc.info/?l=bugtraq&m=121494431426308&w=2
http://www.openwall.com/lists/oss-security/2008/07/07/1
http://www.openwall.com/lists/oss-security/2008/07/07/4
http://www.openwall.com/lists/oss-security/2008/07/08/12
http://www.openwall.com/lists/oss-security/2008/07/10/7
http://www.openwall.com/lists/oss-security/2008/07/13/1
http://www.openwall.com/lists/oss-security/2008/07/15/4
http://www.openwall.com/lists/oss-security/2008/08/01/1
http://www.openwall.com/lists/oss-security/2008/10/15/1
http://www.openwall.com/lists/oss-security/2008/10/20/2
http://www.rdancer.org/vulnerablevim.html
http://www.rdancer.org/vulnerablevim-shellescape.html