Bug 467489
Summary: | Review Request: nwsclient - NetWorkSpaces Client for Python | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Tom "spot" Callaway <tcallawa> |
Component: | Package Review | Assignee: | Orcan Ogetbil <oget.fedora> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting, oget.fedora, pingou |
Target Milestone: | --- | Flags: | oget.fedora:
fedora-review+
tcallawa: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-12-13 14:56:00 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Tom "spot" Callaway
2008-10-17 18:32:09 UTC
Here are the results of my review on this package: * rpmlint says: nwsclient.noarch: W: non-executable-in-bin /usr/bin/PythonNWSSleighWorker.pyc 0644 nwsclient.noarch: W: non-executable-in-bin /usr/bin/PythonNWSSleighWorker.pyo 0644 These files should be excluded. Please see: http://fedoraproject.org/wiki/Packaging/Python#Unnecessary_Byte_compilation * Since this package is a python module, we have to obey the python module naming guidelines: http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Addon_Packages_.28python_modules.29 ? Shall we package the README* files? ? Why is only a subset of the scripts in the scripts directory installed? ? It would be nice if you make a %check section and run as many possible tests as possible from the test directory. * Source0 gives 404 * Providing Eggs for non-setuptools packages is slightly different than for setuptools packages. Please follow: http://fedoraproject.org/wiki/Packaging/Python/Eggs#Providing_Eggs_for_non-setuptools_packages This package isn't a python module, its a python application that includes its own module, thus, it doesn't need to be renamed. The tests can't be run without an nwsserver, so they're not overly useful in %check. The README files are packaged, look closely. :) The PySleighService.py isn't installed on Linux because it is windows specific. All the other scripts are installed. I fixed the Source0 URL, used setuptools-devel, and got rid of the byte compiled files. New SRPM: http://www.auroralinux.org/people/spot/review/new/nwsclient-1.6.3-2.fc11.src.rpm New SPEC: http://www.auroralinux.org/people/spot/review/new/nwsclient.spec All good, except I have an issue with the naming. I know that the package contains a python application, but the doc files, especially /usr/share/doc/nwsclient-1.6.3/nws.client.html gave me the impression that this package's main purpose is usage as a python module. Am I wrong? The main purpose of this package is to provide a python client to communicate with the nwsserver. The module enables you to write python scripts to send jobs to the nwsserver, but it is primarily the python client. ok, convinced :) -------------------------------------------- This package (nwsclient) is APPROVED by oget -------------------------------------------- New Package CVS Request ======================= Package Name: nwsclient Short Description: NetWorkSpaces Client for Python Owners: spot Branches: F-9 F-10 devel InitialCC: ... and it's done. nwsclient-1.6.3-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/nwsclient-1.6.3-2.fc9 nwsclient-1.6.3-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/nwsclient-1.6.3-2.fc10 nwsclient-1.6.3-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. nwsclient-1.6.3-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |