Bug 467490
| Summary: | Review Request: nwsserver - NetWorkSpaces Server for clustering of scripting languages | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom "spot" Callaway <tcallawa> |
| Component: | Package Review | Assignee: | Richard W.M. Jones <rjones> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, pingou, rjones |
| Target Milestone: | --- | Flags: | rjones:
fedora-review+
tcallawa: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.5.2-2.fc10 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-03-09 22:54:13 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Tom "spot" Callaway
2008-10-17 18:33:25 UTC
rpmlint is silent. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1226938 + rpmlint output
+ package name satisfies the packaging naming guidelines
Although implemented in python, this is just a general program,
and the name of the program is acceptable to Fedora.
+ specfile name matches the package base name
+ package should satisfy packaging guidelines
Also checked Python guidelines, and OK.
+ license meets guidelines and is acceptable to Fedora
+ license matches the actual package license
+ %doc includes license file
There isn't a license file, but %doc includes the nearest thing,
and all source files are marked with the license anyway.
+ spec file written in American English
+ spec file is legible
+ upstream sources match sources in the srpm
d321ae5fd3a363167ac27f7959b56c8a / 22331 bytes
+ package successfully builds on at least one architecture
n/a ExcludeArch bugs filed
+ BuildRequires list all build dependencies
n/a %find_lang instead of %{_datadir}/locale/*
n/a binary RPM with shared library files must call ldconfig in %post and %postun
+ does not use Prefix: /usr
+ package owns all directories it creates
+ no duplicate files in %files
+ %defattr line
+ %clean contains rm -rf $RPM_BUILD_ROOT
+ consistent use of macros
+ package must contain code or permissible content
n/a large documentation files should go in -doc subpackage
+ files marked %doc should not affect package
n/a header files should be in -devel
n/a static libraries should be in -static
n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a libfoo.so must go in -devel
n/a -devel must require the fully versioned base
n/a packages should not contain libtool .la files
n/a packages containing GUI apps must include %{name}.desktop file
+ packages must not own files or directories owned by other packages
+ %install must start with rm -rf %{buildroot} etc.
+ filenames must be valid UTF-8
Optional:
? if there is no license file, packager should query upstream
n/a translations of description and summary for non-English languages, if available
+ reviewer should build the package in mock
+ the package should build into binary RPMs on all supported architectures
- review should test the package functions as described
n/a scriptlets should be sane
n/a pkgconfig files should go in -devel
+ shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or /usr/sbin
---------- This package is APPROVED by rjones ---------- New Package CVS Request ======================= Package Name: nwsserver Short Description: NetWorkSpaces Server for clustering of scripting languages Owners: spot Branches: F-9 F-10 devel InitialCC: ... and it's done. nwsserver-1.5.2-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/nwsserver-1.5.2-2.fc9 nwsserver-1.5.2-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/nwsserver-1.5.2-2.fc10 nwsserver-1.5.2-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. nwsserver-1.5.2-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |