Bug 467644
| Summary: | Review Request: sugar-memorize - Memorize for Sugar | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabian Affolter <mail> |
| Component: | Package Review | Assignee: | Simon Schampijer <simon> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, mpg, notting, simon |
| Target Milestone: | --- | Flags: | simon:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-12-09 11:32:22 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 462625 | ||
|
Description
Fabian Affolter
2008-10-19 22:02:13 UTC
To play sounds memorize is dependent on csound. The fedora csound package does not contain the opcode to play ogg vorbis AFAIK http://koji.fedoraproject.org/koji/buildinfo?buildID=33799. OLPC is using a specialized csound package http://koji.fedoraproject.org/koji/packageinfo?packageID=6247 which contains this opcode. Not sure yet how best to go forward, have to examine in more detail. One way would probably be to integrate sugar-memorize with no sound in Fedora for now. And fix this in the near future. There was a patch added to csound (named csound-5.03.0-add-oggplay.patch), maybe this solve the problem but I didn't investigate this further. http://koji.fedoraproject.org/koji/rpminfo?rpmID=205447 The current version of csound is 5.09. At the moment available for Fedora 5.07. Uploaded a new tarball - and fixed all the permission bits etc. so you can remove all of those :) http://dev.laptop.org/pub/sugar/sources/Memorize/Memorize-29.tar.bz2 re: csound: I am ok with leaving the sound support out for now - but we should make sure we keep on working on that - would be nice to have - also we have to inspect sound support anyhow since we don't run pulseaudio on the XO. The patch you showed should work - i wrote that one - but it was added to the olpc-2 build only and we could make sure as well to update to the latest csound sources - as they contain the patch AFAIK. r+ anyway - when removing the hacks i fixed in the sources. Update Spec URL: http://fab.fedorapeople.org/packages/XO/sugar-memorize.spec SRPM URL: http://fab.fedorapeople.org/packages/XO/sugar-memorize-29-1.fc10.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=938635 Simon, did you do a full review? I'm just asking because the flag is set to '+' but the bug is not assigned to you. Yup I did a full review. In the spec you posted above - the comment says that this is removed but it is still present :)
{{{
#delete hidden files
find %{buildroot} -name '.*' -exec rm -f {} ';'
#wrong end-line-encoding
#sed -i 's/\r//' %{buildroot}%{sugaractivitydir}Memorize.activity/images/stock-buddy.svg
#fix rpmlint non-executable-script error
#find %{buildroot}%{sugaractivitydir}Memorize.activity/*.py -type f | xargs chmod a+x
#find %{buildroot}%{sugaractivitydir}Memorize.activity/csound/csoundserver.py -type f | xargs chmod a+x
#remove exec bit
#find %{buildroot}%{sugaractivitydir}Memorize.activity/images/*.svg -type f -name \* -exec chmod 644 {} \;
}}}
Like in the other review, I have to repost the spec file and the SRPM. again, Spec URL: http://fab.fedorapeople.org/packages/XO/sugar-memorize.spec SRPM URL: http://fab.fedorapeople.org/packages/XO/sugar-memorize-29-1.fc10.src.rpm Thanks for your patience You have uncommented the lines now - shouldn't we just remove them? Oh, maybe you wanted to keep it for the git checkout - i have fixed all the upstream sources - so we are save now. I guess it is time to request CVS branches now http://fedoraproject.org/wiki/CVSAdminProcedure :) Thanks Simon. I will remove the lines before cvs check-in. New Package CVS Request ======================= Package Name: sugar-memorize Short Description: Memorize for Sugar Owners: fab Branches: F-10 InitialCC: cvs done. Awesome, this is something we would like to have for Soas: http://dev.sugarlabs.org/ticket/65 sugar-memorize-29-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/sugar-memorize-29-1.fc10 sugar-memorize-29-1.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update sugar-memorize'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2008-10608 sugar-memorize-29-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |