Bug 468116
| Summary: | Review Request: sugar-analyze - Analysing tool for Sugar | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabian Affolter <mail> |
| Component: | Package Review | Assignee: | Marco Pesenti Gritti <mpg> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, mpg, notting |
| Target Milestone: | --- | Flags: | mpg:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-11-27 02:12:20 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 462625 | ||
|
Description
Fabian Affolter
2008-10-22 22:20:09 UTC
Can you explain why you need to make some of the files executable? When that's sorted out, I can make a release we can use instead of git. rpmlint complain about the permission [fab@laptop24 noarch]$ rpmlint -i sugar-analyze-7-1.fc10.noarch.rpm sugar-analyze.noarch: E: non-executable-script /usr/share/sugar/activities/Analyze.activity/procmem/analysis.py 0644 This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. ... ... Ok, I would like to get that fixed upstream. I sent mail to the maintainer with you in cc. We have a release with the fix: http://dev.laptop.org/pub/sugar/sources/Analyze/Analyze-8.tar.bz2 Can you please update the spec/package? Sure, I will make an update over the weekend. Updated Spec URL: http://fab.fedorapeople.org/packages/XO/sugar-analyze.spec SRPM URL: http://fab.fedorapeople.org/packages/XO/sugar-analyze-8-1.fc10.src.rpm Can you please confirm if "mkdir -p %{buildroot}%{sugaractivitydir}" is actually necessary? I'd expect setup.py to take care of it.
Anyway r+. Thanks!
(you forgot to set fedora-review to ?)
(In reply to comment #7) > Can you please confirm if "mkdir -p %{buildroot}%{sugaractivitydir}" is > actually necessary? I'd expect setup.py to take care of it. You are right, 'mkdir -p %{buildroot}%{sugaractivitydir}' is not needed. > Anyway r+. Thanks! > > (you forgot to set fedora-review to ?) Did you do a full review? The flag is set to '+' but the bug is not assigned to you. Spec URL: http://fab.fedorapeople.org/packages/XO/sugar-analyze.spec SRPM URL: http://fab.fedorapeople.org/packages/XO/sugar-analyze-8-2.fc10.src.rpm Yeah I did a full review. Reassigning to me now, I missed that part of the process. New Package CVS Request ======================= Package Name: sugar-analyze Short Description: Analysing tool for Sugar Owners: fab Branches: F-10 InitialCC: cvs done. sugar-analyze-8-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/sugar-analyze-8-2.fc10 sugar-analyze-8-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |