Bug 468226
| Summary: | Review Request: python-tw-jquery - ToscaWidgets wrapping for jQuery | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Luke Macken <lmacken> |
| Component: | Package Review | Assignee: | David Cantrell <dcantrell> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bashton, dcantrell, fedora-package-review, notting, pfrields |
| Target Milestone: | --- | Flags: | jkeating:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.9.5-1.fc10 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-09-29 22:01:48 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Luke Macken
2008-10-23 16:35:46 UTC
Taking review. * Python define good * Source0 is a 404 * Commented out %doc isn't likely commented out. You need %%doc * MANY files lack license header info * PKG-INFO lists the license as UNKNOWN, there is no fallback for unlicensed files. * Some files are licensed under MIT /and/ GPL * rpmlint output: python-tw-jquery.noarch: W: no-documentation python-tw-jquery.noarch: W: hidden-file-or-dir /usr/lib/python2.6/site-packages/tw/jquery/static/css/flexigrid/images/._fhbg.gif python-tw-jquery.noarch: W: hidden-file-or-dir /usr/lib/python2.6/site-packages/tw/jquery/static/css/flexigrid/._ie.css python-tw-jquery.noarch: W: hidden-file-or-dir /usr/lib/python2.6/site-packages/tw/jquery/static/css/flexigrid/._images python-tw-jquery.noarch: W: hidden-file-or-dir /usr/lib/python2.6/site-packages/tw/jquery/static/css/flexigrid/images/._wbg.gif python-tw-jquery.noarch: E: htaccess-file /usr/lib/python2.6/site-packages/tw/jquery/static/javascript/validate/demo/captcha/images/.htaccess python-tw-jquery.noarch: W: hidden-file-or-dir /usr/lib/python2.6/site-packages/tw/jquery/static/css/flexigrid/._flexigrid.css 2 packages and 0 specfiles checked; 1 errors, 6 warnings. ** SUMMARY ** Needs a license audit. Needs an updates Source rpmlint issues need accounting for or fixing. I just did an upstream release that now contains a LICENSE.txt, and I also added the MIT license header to all of the python modules. http://lmacken.fedorapeople.org/rpms/python-tw-jquery-0.9.4.3-1.fc10.src.rpm http://lmacken.fedorapeople.org/rpms/python-tw-jquery.spec * Tue Jun 02 2009 Luke Macken <lmacken> - 0.9.4.3-1 - Latest upstream release * Mon Jun 01 2009 Luke Macken <lmacken> - 0.9.4.2-1 - Update to 0.9.4.2 - Require python-tw-forms * Tue Jun 02 2009 Luke Macken <lmacken> - 0.9.4.4-1 - Latest upstream release, which includes the license http://lmacken.fedorapeople.org/rpms/python-tw-jquery-0.9.4.4-1.fc10.src.rpm rpmlint still takes issues with some of the files, what's going on with those? $ rpmlint ../Download/python-tw-jquery-0.9.4.4-1.fc12.noarch.rpm python-tw-jquery.noarch: W: hidden-file-or-dir /usr/lib/python2.6/site-packages/tw/jquery/static/css/flexigrid/._ie.css python-tw-jquery.noarch: W: hidden-file-or-dir /usr/lib/python2.6/site-packages/tw/jquery/static/css/flexigrid/._images python-tw-jquery.noarch: W: hidden-file-or-dir /usr/lib/python2.6/site-packages/tw/jquery/static/css/flexigrid/images/._wbg.gif python-tw-jquery.noarch: W: hidden-file-or-dir /usr/lib/python2.6/site-packages/tw/jquery/static/css/flexigrid/._flexigrid.css python-tw-jquery.noarch: W: hidden-file-or-dir /usr/lib/python2.6/site-packages/tw/jquery/static/css/flexigrid/images/._fhbg.gif python-tw-jquery.noarch: E: htaccess-file /usr/lib/python2.6/site-packages/tw/jquery/static/javascript/validate/demo/captcha/images/.htaccess http://lmacken.fedorapeople.org/rpms/python-tw-jquery.spec http://lmacken.fedorapeople.org/rpms/python-tw-jquery-0.9.4.5-1.el5.src.rpm * Thu Jun 18 2009 Luke Macken <lmacken> - 0.9.4.5-1 - Latest upstream release, with various module cleanups ping? All good now, approving. New Package CVS Request ======================= Package Name: python-tw-jquery Short Description: ToscaWidgets wrapping for jQuery Owners: lmacken Branches: F-10 F-11 EL-5 CVS done. python-tw-jquery-0.9.5-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/python-tw-jquery-0.9.5-1.fc10 python-tw-jquery-0.9.5-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/python-tw-jquery-0.9.5-1.fc11 python-tw-jquery-0.9.5-1.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/python-tw-jquery-0.9.5-1.el5 python-tw-jquery-0.9.5-1.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-tw-jquery'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2009-0268 python-tw-jquery-0.9.5-1.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-tw-jquery'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-8478 python-tw-jquery-0.9.5-1.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-tw-jquery'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-8500 python-tw-jquery-0.9.5-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. python-tw-jquery-0.9.5-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. python-tw-jquery-0.9.5-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |