Bug 468276

Summary:	doesn't dither background
Product:	[Fedora] Fedora	Reporter:	Bill Nottingham <notting>
Component:	plymouth	Assignee:	Ray Strode [halfline] <rstrode>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	duffy, fedora, krh, rstrode, rvokal
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-10-27 17:00:52 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Bill Nottingham 2008-10-23 20:34:54 UTC

Description of problem:

Best example is comparing the Solar plugin booted with vga=794 vs. vga=795;
with vga=794 it's pretty banded.

Version-Release number of selected component (if applicable):

plymouth-0.6.0-0.2008.10.21.2.fc10.x86_64

Comment 1 Ray Strode [halfline] 2008-10-23 21:39:36 UTC

This is with solar or spinfinity?

We definitely dither gradients.

Comment 2 Bill Nottingham 2008-10-24 00:18:34 UTC

I noticed it with solar. I'm not sure spinfinity uses enough colors to matter.

Comment 3 Ray Strode [halfline] 2008-10-24 13:31:09 UTC

So what's probably going on here is solar uses a background image, while spinfinity uses a dithered generated gradient.

We should either dither the background image or give it a lot of alpha and overlay it on a gradient.

Comment 4 Charlie Brej 2008-10-25 18:08:55 UTC

Patch submitted:
http://lists.freedesktop.org/archives/plymouth/2008-October/000006.html

Before: http://www.cs.man.ac.uk/~brejc8/temp/dither1.jpg
After : http://www.cs.man.ac.uk/~brejc8/temp/dither2.jpg

Comment 5 Ray Strode [halfline] 2008-10-27 17:00:52 UTC

This is building in koji now... Thanks Charlie!