Bug 468329
| Summary: | Review Request: sblim-indication_helper - Toolkit for CMPI Indication Providers | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Matt Domsch <matt_domsch> |
| Component: | Package Review | Assignee: | srinivas <srinivas_ramanatha> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, hdegoede, notting, praveen_paladugu, srinivas_ramanatha, vcrhonek |
| Target Milestone: | --- | Flags: | srinivas_ramanatha:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.4.2-3.el4 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-08-05 04:34:37 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 468400 | ||
|
Description
Matt Domsch
2008-10-24 05:48:49 UTC
sblim-sfcb-base will need a minor update after this package is approved, to BR: sblim-indication_helper-devel, to automatically pick up indication support. ***Unofficial Review***
* rpmlint looks good:
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
3 packages and 0 specfiles checked; 0 errors, 0 warnings.
* Why is your build number 134? I believe it should start at 1.
* You don't need gcc-c++ in your BuildRequires.
* I'd run rpmdev-newspec to create a sample spec file and format yours like that. I think it helps to have everything standardized for when someone looks at it. For instance, you have the 'BuildRequires' tag coming after 'Name' and it should be 'Version'.
* I'm sure you'll do this if you look at the sample spec file but you should use %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) as your BuildRoot.
* Your spec file license shows IBM but the upstream license shows "Common Public License" so this should probably be changed from IBM to CPL.
* You should use Source0: <link> to match the form of SourceX.
* Requires -- you can leave out the following, RPM can figure them out.
Requires: sblim-cmpi-devel glibc-devel
* You should use %{__rm} under %install to be consistent within the spec file.
* You must run %{__rm} -rf %{buildroot} at the beginning of %install.
That's about all I have.
Made the above mentioned changes. Changed the license to CPL since the README mentioned this is code is distributed under CPL. The final versions of the files can be found at: http://linux.dell.com/files/fedora/sblim-indication_helper/sblim-indication_helper-0.4.2-1.fc10.src.rpm http://linux.dell.com/files/fedora/sblim-indication_helper/sblim-indication_helper.spec Please review the above files. The output of rpmlint: [user]# rpmlint sblim-indication_helper.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. The Package naming Guidelines suggest to use '-' between words all the time. The source package in this case, has an "_"(underscore). Should the underscore be changed to a hyphen? Review: Fix all rpmlint errors/warnings: [root@srini-f11 rpmbuild]# rpmlint SPECS/sblim-indication_helper.spec SPECS/sblim-indication_helper.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 11) 0 packages and 1 specfiles checked; 0 errors, 1 warnings. [root@srini-f11 rpmbuild]# rpmlint SRPMS/sblim-indication_helper-0.4.2-1.fc11.src.rpm sblim-indication_helper.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 11) 1 packages and 0 specfiles checked; 0 errors, 1 warnings. [root@srini-f11 rpmbuild]# rpmlint RPMS/x86_64/sblim-indication_helper-* sblim-indication_helper.x86_64: E: devel-dependency glibc-devel sblim-indication_helper-devel.x86_64: W: no-dependency-on sblim-indication_helper/sblim-indication_helper-libs/libsblim-indication_helper 3 packages and 0 specfiles checked; 1 errors, 1 warnings. naming: ok ( I would prefer it to have a "-" between the words) spec file name matches: ok license = CPL : ok license tag: ok spec in english: ok spec legible: ok no prebuild binaries: ok no packager, vendor, copyright, tags: ok summary and description tags: ok no rpaths: ok no config files: ok no initscripts: ok no desktop files: ok consistent use of macros: ok no makeinstall: ok no lang files: ok scriptlets: ok no conditional deps: ok builds with a normal user account: ok not relocatable: ok code, not content: ok directory ownership: ok users and groups: ok not a web app: ok conflicts: ok no kmods: ok no files under /srv: ok source matches: ok calls ldconfig appropriately: ok no duplicate files: ok file permissions: ok libtool archives removed: ok %clean section: ok no large docs, no need for -doc subpackage: ok %doc usage ok no static libs: ok no pkgconfig files: ok all libtool .la files removed: ok dir ownership correct: ok %install does rm: ok filenames UTF8: ok Fixed. The final versions of the files can be found at: http://linux.dell.com/files/fedora/sblim-indication_helper/sblim-indication_helper-0.4.2-3.fc10.src.rpm http://linux.dell.com/files/fedora/sblim-indication_helper/sblim-indication_helper.spec Review approved. Changing the flag to fedora-review "+" New Package CVS Request ======================= Package Name:sblim-indication_helper Short Description: libraries for writing CMPI providers Owners: praveenp,srini Branches:F-9 F-10 F-11 EL-4 EL-5 InitialCC: mdomsch,srini New Package CVS Request ======================= Package Name:sblim-indication_helper Short Description: libraries for writing CMPI providers Owners: praveenp Branches:F-10 F-11 EL-4 EL-5 InitialCC: mdomsch srini CVS done. Builds on all the branches. Closing this issue. sblim-indication_helper-0.4.2-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/sblim-indication_helper-0.4.2-3.fc10 sblim-indication_helper-0.4.2-3.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/sblim-indication_helper-0.4.2-3.fc11 sblim-indication_helper-0.4.2-3.el4 has been submitted as an update for Fedora EPEL 4. http://admin.fedoraproject.org/updates/sblim-indication_helper-0.4.2-3.el4 sblim-indication_helper-0.4.2-3.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/sblim-indication_helper-0.4.2-3.el5 sblim-indication_helper-0.4.2-3.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. sblim-indication_helper-0.4.2-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. sblim-indication_helper-0.4.2-3.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. sblim-indication_helper-0.4.2-3.el4 has been pushed to the Fedora EPEL 4 stable repository. If problems still persist, please make note of it in this bug report. New Package CVS Request ======================= Package Name:sblim-indication_helper Short Description: libraries for writing CMPI providers Owners: praveenp Branches:EPEL-4 EPEL-5 InitialCC: mdomsch srini This package already has EL-4/EL-5 branches. Feel free to add a new request and reset the flag if you need anything further. (In reply to comment #1) > sblim-sfcb-base will need a minor update after this package is approved, to BR: > sblim-indication_helper-devel, to automatically pick up indication support. This part didn't appear to happen. |