Bug 468467
| Summary: | Review Request: gksu - Graphical frontend to su | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Simon <cassmodiah> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | alexjnewt, christoph.wickert, dijit, fedora-package-review, mail, notting |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-12-27 01:05:20 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Simon
2008-10-24 20:44:10 UTC
Some quick comments... - You added 'BuildRequires: gettext-devel' 'BuildRequires: gettext' is sufficient - I guess that all patches are coming from Debian. Am I right? https://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment - Is rpmlint not complaining about the NEWS file? - In this tarball is a .desktop file too. You should add it. libgksu: gksu-properties.desktop gksu: gksu.desktop NEWS-file sorry, I have forget it to remove the NEWS-file, its an empty file gettext-devel. Strange, i made this error in every package, up to now, sorry! The Desktopfile It's a little tricky. The desktopfile tries to open a terminalemulator via gksu /usr/bin/x-terminal-emulator x-terminal-emulator is a setting in update-alternatives for debian and debian based distros. seems like fedora don't use this or a similar alternative to set a terminal. so this file will be needless, or? all patches are from the gksu-debianpackage upstream = debian package maintainer of gksu & libgksu fixed: news file and gettext and patchcomment, split the nautlis extension in an extra subpackage SPEC: http://cassmodiah.fedorapeople.org/gksu-2.0.0/gksu.spec URL: http://cassmodiah.fedorapeople.org/gksu-2.0.0/gksu-2.0.0-2.fc10.src.rpm Only rpmlint-error: gksu-nautilus-extension.i386: W: devel-file-in-non-devel-package /usr/lib/nautilus/extensions-2.0/libnautilus-gksu.a i think this won't be a problem, or? close bug, because there is no benefit for fedora if you`re not agree and think this would be a good package you can reopen it. the spec and srpm will be preserved. I have to use a program that requires gksu, I could patch the application or ask upstream to change it but it seems like too much work and I don't see why gksu can't be included in Fedora anyway. I would hope this can be re-opened as I also have another program I need to use for work that's not open source that depends on gksu. Does anyone have a copy of the spec or src RPM? The links are dead |