Bug 468504
Summary: | preupgrade fail | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Alexey Kuznetsov <axet> | ||||
Component: | anaconda | Assignee: | Anaconda Maintenance Team <anaconda-maint-list> | ||||
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | 9 | CC: | anaconda-maint-list | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2008-11-04 15:56:00 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
What does your /etc/ffstab look like? ah, sorry here is: [axet@axet-laptop ~]$ cat /etc/fstab UUID=17050de4-c9bc-4938-9615-090c227ce8fb / ext3 defaults 1 1 tmpfs /dev/shm tmpfs defaults 0 0 devpts /dev/pts devpts gid=5,mode=620 0 0 sysfs /sys sysfs defaults 0 0 proc /proc proc defaults 0 0 /var/swap swap swap [axet@axet-laptop ~]$ ll /var/swap -rw-r--r-- 1 root root 2147483648 2008-10-16 01:27 /var/swap [axet@axet-laptop ~]$ Can you add 'updates=http://katzj.fedorapeople.org/updates-468504.cgz' to the kernel command line for preupgrade and see if it fixes things for you? diff --git a/fsset.py b/fsset.py index a1fdaef..f55e3cb 100644 --- a/fsset.py +++ b/fsset.py @@ -1974,7 +1974,7 @@ MAILADDR root else: continue else: - if anaconda.id.getUpgrade() and not (entry.getLabel() or entry.getUuid()): + if anaconda.id.getUpgrade() and not (entry.getLabel() or entry.getUuid()) and entry.device.getDevice().startswith("/dev"): errStr = _("Error mounting device %s as %s: " "%s\n\n" "Devices in /etc/fstab should be specified " In my opinion better to have some function who can test file for it's kind: device or file. Funtion can be more cleanly for source code, then magic if. Do you still think your solution is good enough? It's sufficient... and if it works, then I'll probably make it a little bit cleaner when really committing it :) But quick and dirty is better for testing ok as you wish. i will create new vm machine for test, take a while.. i can't reproduce it on my virtual machine, do you change something already in repo? This should be fixed as of the October 29th build. Jeremy committed the fix prior to that date. |
Created attachment 321500 [details] error i run preupgrate from f9 to f10rawhide and got attached error. problem happens because i use swap in file located in my file system.