Bug 468579

Only some quick comment about the rpmlint output and your spec file...

Spec file:

Detail about packaging python stuff: https://fedoraproject.org/wiki/Packaging/Python

Name: PyQuante
 - The name of your package should be lower case
   https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Case_Sensitivity

BuildRequires
 - 'BuildRequires:   python' is missing

% files
 - Please follow the guidelines https://fedoraproject.org/wiki/Packaging/Python#System_Architecture

%changelog
 - E mail address is missing
   https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs

rpmlint output:

(In reply to comment #0)
> PyQuante.x86_64: E: non-executable-script
> /usr/lib64/python2.5/site-packages/PyQuante/Minimizers.py 0644

You can add something like 'find  *.py -type f | xargs chmod a+x' to fix this.

> PyQuante.x86_64: E: wrong-script-end-of-line-encoding
> /usr/lib64/python2.5/site-packages/PyQuante/pressure.py

If you have to remove DOS line endings in this file 'sed -i 's/\r$//' file.py'

> PyQuante.x86_64: W: invalid-license Modified BSD
> PyQuante-debuginfo.x86_64: W: invalid-license Modified BSD

For a valid license for Fedora, please take a look at https://fedoraproject.org/wiki/Licensing

ping?

Sorry, I'll get right on it.

(In reply to comment #1)
> Only some quick comment about the rpmlint output and your spec file...
> 
> Spec file:
> 
> Detail about packaging python stuff:
> https://fedoraproject.org/wiki/Packaging/Python
> 
> Name: PyQuante
>  - The name of your package should be lower case
>    https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Case_Sensitivity

The author refers to the software as PyQuante, also the python modules are called PyQuante. Refer to ORBit in Naming Guidelines.

> BuildRequires
>  - 'BuildRequires:   python' is missing

It is already required by python-setuptools-devel (and numpy too?).
 
> % files
>  - Please follow the guidelines
> https://fedoraproject.org/wiki/Packaging/Python#System_Architecture

Hmm, I thought I already was following them. I can't find anything wrong with using %{python_sitearch} as defined in the Python guidelines. PyQuante contains compiled C code in the modules..

>> PyQuante.x86_64: E: non-executable-script
>> /usr/lib64/python2.5/site-packages/PyQuante/Minimizers.py 0644
>
>You can add something like 'find  *.py -type f | xargs chmod a+x' to fix this.

If I do that then I get script-without-shebang errors.
Besides, the files in site-packages don't need to be executable, since they just contain modules used by the frontend software.

Check your python-sitelib directory, only a small minority of the .py files are executable. rpmlint shouldn't complain about this.

> > PyQuante.x86_64: W: invalid-license Modified BSD
> > PyQuante-debuginfo.x86_64: W: invalid-license Modified BSD
> 
> For a valid license for Fedora, please take a look at
> https://fedoraproject.org/wiki/Licensing

Yeah, but the license is not word-for-word BSD.

http://theory.physics.helsinki.fi/~jzlehtol/rpms/PyQuante.spec
http://theory.physics.helsinki.fi/~jzlehtol/rpms/PyQuante-1.6.1-2.fc9.src.rpm

(In reply to comment #4)
> (In reply to comment #1)
> > Name: PyQuante
> >  - The name of your package should be lower case
> >    https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Case_Sensitivity
> 
> The author refers to the software as PyQuante, also the python modules are
> called PyQuante. Refer to ORBit in Naming Guidelines.

OK 

> > BuildRequires
> >  - 'BuildRequires:   python' is missing
> 
> It is already required by python-setuptools-devel (and numpy too?).

python is no longer in the default packageset. 
https://fedoraproject.org/wiki/Packaging/Python#BuildRequires

> > % files
> >  - Please follow the guidelines
> > https://fedoraproject.org/wiki/Packaging/Python#System_Architecture
> 
> Hmm, I thought I already was following them. I can't find anything wrong with
> using %{python_sitearch} as defined in the Python guidelines. PyQuante contains
> compiled C code in the modules..

I guess that I have had %{python_sitearch}/* in my mind.  But I can remember if I thought about %{python_sitearch}/modulename/*

> >> PyQuante.x86_64: E: non-executable-script
> >> /usr/lib64/python2.5/site-packages/PyQuante/Minimizers.py 0644
> >
> >You can add something like 'find  *.py -type f | xargs chmod a+x' to fix this.
> 
> If I do that then I get script-without-shebang errors.
> Besides, the files in site-packages don't need to be executable, since they
> just contain modules used by the frontend software.
> 
> Check your python-sitelib directory, only a small minority of the .py files are
> executable. rpmlint shouldn't complain about this.

I will take a look at it.
 
> > > PyQuante.x86_64: W: invalid-license Modified BSD
> > > PyQuante-debuginfo.x86_64: W: invalid-license Modified BSD
> > 
> > For a valid license for Fedora, please take a look at
> > https://fedoraproject.org/wiki/Licensing
> 
> Yeah, but the license is not word-for-word BSD.

The license looks like MIT 'Old Style with legal disclaimer 3'
http://fedoraproject.org/wiki/Licensing/MIT

Fixed license tag to BSD (the license is almost the same as New BSD 3 clause license, only difference is

BSD:
THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS AS IS

PyQuante:
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS AS IS


I don't think there's anything wrong with the %files section, since the package doesn't end up owning any directories or files it shouldn't.


http://theory.physics.helsinki.fi/~jzlehtol/rpms/PyQuante.spec
http://theory.physics.helsinki.fi/~jzlehtol/rpms/PyQuante-1.6.1-3.fc9.src.rpm

Ping; Fabian, are you going to review the package?

- '%{!?python_sitelib: ...' is not needed at the top of the spec file.
- Source URL should be 
  http://downloads.sourceforge.net/pyquante/%{name}-%{version}.tar.gz

- (In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #1)
> > >> PyQuante.x86_64: E: non-executable-script
> > >> /usr/lib64/python2.5/site-packages/PyQuante/Minimizers.py 0644
> > >
> > >You can add something like 'find  *.py -type f | xargs chmod a+x' to fix this.
> > 
> > If I do that then I get script-without-shebang errors.
> > Besides, the files in site-packages don't need to be executable, since they
> > just contain modules used by the frontend software.
> > 
> > Check your python-sitelib directory, only a small minority of the .py files are
> > executable. rpmlint shouldn't complain about this.

Will upstream fix this?  If the modules only are used by the frontend then the shebang can be removed (and then the rpmlint errors will disappear, I guess)

Is the line encodings fixing not better be done in the %prep section?

Okay, I've removed the shebangs, and the package still works.
rpmlint output is now clean.

http://theory.physics.helsinki.fi/~jzlehtol/rpms/PyQuante.spec
http://theory.physics.helsinki.fi/~jzlehtol/rpms/PyQuante-1.6.1-4.fc10.src.rpm

Added tests directory.

http://theory.physics.helsinki.fi/~jzlehtol/rpms/PyQuante.spec
http://theory.physics.helsinki.fi/~jzlehtol/rpms/PyQuante-1.6.1-5.fc10.src.rpm


Also, I've contacted upstream about the shebangs; they will be removed in the next release.

Coordinated fixes with upstream. Rpmlint output is now clean.

http://theory.physics.helsinki.fi/~jzlehtol/rpms/PyQuante.spec
http://theory.physics.helsinki.fi/~jzlehtol/rpms/PyQuante-1.6.3-1.fc10.src.rpm

Package Review
==============

Package: 

Key:
 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format %{name}.spec.
 [x] Package meets the Packaging Guidelines
 [x] Package successfully compiles and builds into binary RPMs on at least one
supported architecture.
     Tested on: F10/i386
 [x] Rpmlint output:
     Source RPM:
     [fab@laptop24 SRPMS]$ rpmlint PyQuante-1.6.3-1.fc10.src.rpm 
     1 packages and 0 specfiles checked; 0 errors, 0 warnings.
     Binary RPM(s):
     [fab@laptop24 i386]$ rpmlint PyQuante-1.6.3-1.fc10.i386.rpm 
     1 packages and 0 specfiles checked; 0 errors, 0 warnings.
 [x] Package is not relocatable.
 [x] Buildroot is correct
     master   : %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
     spec file: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
     License type: BSD
 [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc.

 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
     Upstream source: 5e44d1e67a4f62da69ade7e26e53ab7b
     Build source:    5e44d1e67a4f62da69ade7e26e53ab7b
 [x] Package is not known to require ExcludeArch.
 [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.  %find_lang used for locales.
 [-] %{optflags} or RPM_OPT_FLAGS are honoured.
 [-] ldconfig called in %post and %postun if required.
 [x] %install starts with rm -rf %{buildroot} or $RPM_BUILD_ROOT.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not own files or directories owned by other packages.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly. %defattr(-,root,root,-) is in every %files section.
 [x] Package uses nothing in %doc for runtime.
 [x] Package has a %clean section, which contains rm -rf %{buildroot} or $RPM_BUILD_ROOT.
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.

 [-] Large documentation files are in a -doc subpackage, if required.
 [-] Header files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Package does not contain any libtool archives (.la).
 [x] -debuginfo subpackage is present and looks complete.
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI application.

=== SUGGESTED ITEMS ===
 [-] Timestamps preserved with cp and install.
 [-] Uses parallel make (%{?_smp_mflags})
 [x] Latest version is packaged.
 [-] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Tested on: F10/i386
 [x] Package should compile and build into binary RPMs on all supported
architectures.
     Tested:  http://koji.fedoraproject.org/koji/taskinfo?taskID=1228388
 [x] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [-] File based requires are sane.
 [x] Changelog in allowed format

I see no further blocker, package APPROVED

Thanks for the review.

New Package CVS Request
=======================
Package Name: PyQuante
Short Description: Python Quantum Chemistry
Owners: jussilehtola
Branches: F-9 F-10
InitialCC:

cvs done.

Oh, I need EPEL branches, too. Sorry.

Package Change Request
======================
Package Name: PyQuante
New Branches: EL-5
Owners: jussilehtola

PyQuante-1.6.3-1.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/PyQuante-1.6.3-1.fc10

PyQuante-1.6.3-1.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/PyQuante-1.6.3-1.fc9

cvs done.

PyQuante-1.6.3-1.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

PyQuante-1.6.3-1.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.