Bug 468848

Summary: Review Request: hunspell-fa - Farsi hunspell dictionaries
Product: [Fedora] Fedora Reporter: Caolan McNamara <caolanm>
Component: Package ReviewAssignee: Parag AN(पराग) <panemade>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting, panemade
Target Milestone: ---Flags: panemade: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-10-29 23:19:15 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Caolan McNamara 2008-10-28 11:44:00 UTC
Spec URL: http://people.redhat.com/caolanm/hunspell/hunspell-fa.spec
SRPM URL: http://people.redhat.com/caolanm/hunspell/hunspell-fa-0.20070116-1.fc9.src.rpm
Description: Farsi hunspell dictionaries

Comment 1 Parag AN(पराग) 2008-10-29 05:56:21 UTC
Review:
+ package builds in mock.
 Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=910220
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
47c8599e529fc291a096c12f0b8372ca  aspell6-fa-0.11-0.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.

APPROVED.

Comment 2 Caolan McNamara 2008-10-29 09:52:43 UTC
New Package CVS Request
=======================
Package Name: hunspell-fa
Short Description: Farsi hunspell dictionaries
Owners: caolanm
Branches: 
InitialCC:

Comment 3 Kevin Fenzi 2008-10-29 20:53:35 UTC
cvs done.