Bug 469002

Summary: Review Request: sblim-gather - SBLIM Gatherer
Product: [Fedora] Fedora Reporter: Vitezslav Crhonek <vcrhonek>
Component: Package ReviewAssignee: Roman Rakus <rrakus>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, matt_domsch, notting, praveen_paladugu, rrakus, shyam_iyer, tsmetana, wwlinuxengineering
Target Milestone: ---Flags: rrakus: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-10-22 11:34:51 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 468400    

Description Vitezslav Crhonek 2008-10-29 13:19:50 UTC
Spec URL: http://vcrhonek.fedorapeople.org/sblim-gather/sblim-gather.spec
SRPM URL: http://vcrhonek.fedorapeople.org/sblim-gather/sblim-gather-2.1.2-1.fc9.src.rpm
Description: Standards Based Linux Instrumentation for Manageability
Performance Data Gatherer Base.
This package contains the agents and control programs for gathering
and providing performance data.

Comment 1 Praveen K Paladugu 2009-08-20 21:39:24 UTC
Hey Vitezslav,
 The link for the SRPM is not working. Could you please check?

Comment 3 Praveen K Paladugu 2009-08-25 20:06:07 UTC
REVIEW::


user1# rpmlint sblim-gather.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
user1# rpmlint sblim-gather-2.1.2-1.fc10.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

user1# rpmlint sblim-gather-2.1.2-1.fc10.i386.rpm
sblim-gather.i386: W: devel-file-in-non-devel-package /usr/lib/gather/mplug/libmetricNetworkPort.so
sblim-gather.i386: W: devel-file-in-non-devel-package /usr/lib/gather/mplug/libmetriczCH.so
sblim-gather.i386: W: devel-file-in-non-devel-package /usr/lib/gather/rplug/librepositoryProcessor.so
sblim-gather.i386: W: devel-file-in-non-devel-package /usr/lib/gather/rplug/librepositoryUnixProcess.so
sblim-gather.i386: W: devel-file-in-non-devel-package /usr/lib/gather/rplug/librepositoryzCH.so
sblim-gather.i386: W: devel-file-in-non-devel-package /usr/lib/gather/rplug/librepositoryLocalFileSystem.so
sblim-gather.i386: W: devel-file-in-non-devel-package /usr/lib/gather/rplug/librepositoryzLPAR.so
sblim-gather.i386: W: devel-file-in-non-devel-package /usr/lib/gather/rplug/librepositoryOperatingSystem.so
sblim-gather.i386: W: devel-file-in-non-devel-package /usr/lib/gather/mplug/libmetriczLPAR.so
sblim-gather.i386: W: devel-file-in-non-devel-package /usr/lib/gather/mplug/libmetricXen.so
sblim-gather.i386: W: devel-file-in-non-devel-package /usr/lib/gather/mplug/libmetricLocalFileSystem.so
sblim-gather.i386: W: devel-file-in-non-devel-package /usr/lib/gather/mplug/libmetricIPProtocolEndpoint.so
sblim-gather.i386: W: devel-file-in-non-devel-package /usr/lib/gather/mplug/libmetriczECKD.so
sblim-gather.i386: W: devel-file-in-non-devel-package /usr/lib/gather/rplug/librepositoryIPProtocolEndpoint.so
sblim-gather.i386: W: devel-file-in-non-devel-package /usr/lib/gather/mplug/libmetricUnixProcess.so
sblim-gather.i386: W: devel-file-in-non-devel-package /usr/lib/gather/mplug/libmetricOperatingSystem.so
sblim-gather.i386: W: devel-file-in-non-devel-package /usr/lib/gather/rplug/librepositoryNetworkPort.so
sblim-gather.i386: W: devel-file-in-non-devel-package /usr/lib/gather/mplug/libmetricProcessor.so
sblim-gather.i386: W: devel-file-in-non-devel-package /usr/lib/gather/mplug/libmetriczCEC.so
sblim-gather.i386: W: devel-file-in-non-devel-package /usr/lib/gather/rplug/librepositoryzECKD.so
sblim-gather.i386: W: devel-file-in-non-devel-package /usr/lib/gather/rplug/librepositoryzCEC.so
sblim-gather.i386: W: devel-file-in-non-devel-package /usr/lib/gather/rplug/librepositoryXen.so


user1# rpmlint sblim-gather-provider-2.1.2-1.fc10.i386.rpm
sblim-gather-provider.i386: W: no-documentation
sblim-gather-provider.i386: W: devel-file-in-non-devel-package /usr/lib/gather/cplug/libcimplugzLPAR.so
sblim-gather-provider.i386: W: devel-file-in-non-devel-package /usr/lib/gather/cplug/libcimplugUnixProcess.so
sblim-gather-provider.i386: W: devel-file-in-non-devel-package /usr/lib/cmpi/libOSBase_MetricForMEProvider.so
sblim-gather-provider.i386: W: devel-file-in-non-devel-package /usr/lib/gather/cplug/libcimplugIPProtocolEndpoint.so
sblim-gather-provider.i386: W: devel-file-in-non-devel-package /usr/lib/cmpi/libOSBase_MetricDefinitionProvider.so
sblim-gather-provider.i386: W: devel-file-in-non-devel-package /usr/lib/gather/cplug/libcimplugzCEC.so
sblim-gather-provider.i386: W: devel-file-in-non-devel-package /usr/lib/cmpi/libOSBase_MetricValueProvider.so
sblim-gather-provider.i386: W: devel-file-in-non-devel-package /usr/lib/gather/cplug/libcimplugOperatingSystem.so
sblim-gather-provider.i386: W: devel-file-in-non-devel-package /usr/lib/cmpi/libOSBase_MetricGathererProvider.so
sblim-gather-provider.i386: W: devel-file-in-non-devel-package /usr/lib/gather/cplug/libcimplugzECKD.so
sblim-gather-provider.i386: W: devel-file-in-non-devel-package /usr/lib/cmpi/libOSBase_MetricInstanceProvider.so
sblim-gather-provider.i386: W: devel-file-in-non-devel-package /usr/lib/cmpi/libOSBase_MetricRepositoryServiceProvider.so
sblim-gather-provider.i386: W: devel-file-in-non-devel-package /usr/lib/gather/cplug/libcimplugLocalFileSystem.so
sblim-gather-provider.i386: W: devel-file-in-non-devel-package /usr/lib/gather/cplug/libcimplugzCH.so
sblim-gather-provider.i386: W: devel-file-in-non-devel-package /usr/lib/gather/cplug/libcimplugNetworkPort.so
sblim-gather-provider.i386: W: devel-file-in-non-devel-package /usr/lib/gather/cplug/libcimplugXen.so
sblim-gather-provider.i386: W: devel-file-in-non-devel-package /usr/lib/gather/cplug/libcimplugProcessor.so
sblim-gather-provider.i386: W: devel-file-in-non-devel-package /usr/lib/cmpi/libOSBase_MetricIndicationProvider.so
sblim-gather-provider.i386: W: devel-file-in-non-devel-package /usr/lib/cmpi/libOSBase_MetricDefForMEProvider.so


user1# rpmlint sblim-gather-devel-2.1.2-1.fc10.i386.rpm
sblim-gather-devel.i386: W: no-documentation

user1# sblim-gather-test-2.1.2-1.fc10.i386.rpm
sblim-gather-test.i386: W: no-documentation


**Please add comments about the patches if you can.

Comment 4 Vitezslav Crhonek 2009-09-02 10:52:22 UTC
(In reply to comment #3)
> REVIEW::
> 
> 
> user1# rpmlint sblim-gather.spec 
> 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
> user1# rpmlint sblim-gather-2.1.2-1.fc10.src.rpm
> 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
> 
> user1# rpmlint sblim-gather-2.1.2-1.fc10.i386.rpm
> sblim-gather.i386: W: devel-file-in-non-devel-package
> /usr/lib/gather/mplug/libmetricNetworkPort.so
> sblim-gather.i386: W: devel-file-in-non-devel-package
> /usr/lib/gather/mplug/libmetriczCH.so
> sblim-gather.i386: W: devel-file-in-non-devel-package
> /usr/lib/gather/rplug/librepositoryProcessor.so
> sblim-gather.i386: W: devel-file-in-non-devel-package
> /usr/lib/gather/rplug/librepositoryUnixProcess.so
> sblim-gather.i386: W: devel-file-in-non-devel-package
> /usr/lib/gather/rplug/librepositoryzCH.so
> sblim-gather.i386: W: devel-file-in-non-devel-package
> /usr/lib/gather/rplug/librepositoryLocalFileSystem.so
> sblim-gather.i386: W: devel-file-in-non-devel-package
> /usr/lib/gather/rplug/librepositoryzLPAR.so
> sblim-gather.i386: W: devel-file-in-non-devel-package
> /usr/lib/gather/rplug/librepositoryOperatingSystem.so
> sblim-gather.i386: W: devel-file-in-non-devel-package
> /usr/lib/gather/mplug/libmetriczLPAR.so
> sblim-gather.i386: W: devel-file-in-non-devel-package
> /usr/lib/gather/mplug/libmetricXen.so
> sblim-gather.i386: W: devel-file-in-non-devel-package
> /usr/lib/gather/mplug/libmetricLocalFileSystem.so
> sblim-gather.i386: W: devel-file-in-non-devel-package
> /usr/lib/gather/mplug/libmetricIPProtocolEndpoint.so
> sblim-gather.i386: W: devel-file-in-non-devel-package
> /usr/lib/gather/mplug/libmetriczECKD.so
> sblim-gather.i386: W: devel-file-in-non-devel-package
> /usr/lib/gather/rplug/librepositoryIPProtocolEndpoint.so
> sblim-gather.i386: W: devel-file-in-non-devel-package
> /usr/lib/gather/mplug/libmetricUnixProcess.so
> sblim-gather.i386: W: devel-file-in-non-devel-package
> /usr/lib/gather/mplug/libmetricOperatingSystem.so
> sblim-gather.i386: W: devel-file-in-non-devel-package
> /usr/lib/gather/rplug/librepositoryNetworkPort.so
> sblim-gather.i386: W: devel-file-in-non-devel-package
> /usr/lib/gather/mplug/libmetricProcessor.so
> sblim-gather.i386: W: devel-file-in-non-devel-package
> /usr/lib/gather/mplug/libmetriczCEC.so
> sblim-gather.i386: W: devel-file-in-non-devel-package
> /usr/lib/gather/rplug/librepositoryzECKD.so
> sblim-gather.i386: W: devel-file-in-non-devel-package
> /usr/lib/gather/rplug/librepositoryzCEC.so
> sblim-gather.i386: W: devel-file-in-non-devel-package
> /usr/lib/gather/rplug/librepositoryXen.so

I suggest to ignore this warning, these files are not supposed
to be in -devel package.

> 
> 
> user1# rpmlint sblim-gather-provider-2.1.2-1.fc10.i386.rpm
> sblim-gather-provider.i386: W: no-documentation
> sblim-gather-provider.i386: W: devel-file-in-non-devel-package
> /usr/lib/gather/cplug/libcimplugzLPAR.so
> sblim-gather-provider.i386: W: devel-file-in-non-devel-package
> /usr/lib/gather/cplug/libcimplugUnixProcess.so
> sblim-gather-provider.i386: W: devel-file-in-non-devel-package
> /usr/lib/cmpi/libOSBase_MetricForMEProvider.so
> sblim-gather-provider.i386: W: devel-file-in-non-devel-package
> /usr/lib/gather/cplug/libcimplugIPProtocolEndpoint.so
> sblim-gather-provider.i386: W: devel-file-in-non-devel-package
> /usr/lib/cmpi/libOSBase_MetricDefinitionProvider.so
> sblim-gather-provider.i386: W: devel-file-in-non-devel-package
> /usr/lib/gather/cplug/libcimplugzCEC.so
> sblim-gather-provider.i386: W: devel-file-in-non-devel-package
> /usr/lib/cmpi/libOSBase_MetricValueProvider.so
> sblim-gather-provider.i386: W: devel-file-in-non-devel-package
> /usr/lib/gather/cplug/libcimplugOperatingSystem.so
> sblim-gather-provider.i386: W: devel-file-in-non-devel-package
> /usr/lib/cmpi/libOSBase_MetricGathererProvider.so
> sblim-gather-provider.i386: W: devel-file-in-non-devel-package
> /usr/lib/gather/cplug/libcimplugzECKD.so
> sblim-gather-provider.i386: W: devel-file-in-non-devel-package
> /usr/lib/cmpi/libOSBase_MetricInstanceProvider.so
> sblim-gather-provider.i386: W: devel-file-in-non-devel-package
> /usr/lib/cmpi/libOSBase_MetricRepositoryServiceProvider.so
> sblim-gather-provider.i386: W: devel-file-in-non-devel-package
> /usr/lib/gather/cplug/libcimplugLocalFileSystem.so
> sblim-gather-provider.i386: W: devel-file-in-non-devel-package
> /usr/lib/gather/cplug/libcimplugzCH.so
> sblim-gather-provider.i386: W: devel-file-in-non-devel-package
> /usr/lib/gather/cplug/libcimplugNetworkPort.so
> sblim-gather-provider.i386: W: devel-file-in-non-devel-package
> /usr/lib/gather/cplug/libcimplugXen.so
> sblim-gather-provider.i386: W: devel-file-in-non-devel-package
> /usr/lib/gather/cplug/libcimplugProcessor.so
> sblim-gather-provider.i386: W: devel-file-in-non-devel-package
> /usr/lib/cmpi/libOSBase_MetricIndicationProvider.so
> sblim-gather-provider.i386: W: devel-file-in-non-devel-package
> /usr/lib/cmpi/libOSBase_MetricDefForMEProvider.so
> 

Again, this is intention.

> 
> user1# rpmlint sblim-gather-devel-2.1.2-1.fc10.i386.rpm
> sblim-gather-devel.i386: W: no-documentation
> 
> user1# sblim-gather-test-2.1.2-1.fc10.i386.rpm
> sblim-gather-test.i386: W: no-documentation
> 
> 
> **Please add comments about the patches if you can.  

Done.

Comment 5 Vitezslav Crhonek 2009-10-01 12:41:54 UTC
Latest SPEC and SRPM (based on 2.1.9 upstream version) here:
http://vcrhonek.fedorapeople.org/sblim-gather/

Comment 6 Roman Rakus 2009-10-02 12:23:12 UTC
Should own dir /usr/lib64/gather
Dir /usr/share/sblim-testsuite should not be owned

Comment 7 Vitezslav Crhonek 2009-10-13 14:25:09 UTC
(In reply to comment #6)
> Should own dir /usr/lib64/gather

Fixed.

> Dir /usr/share/sblim-testsuite should not be owned  

Fixed. I also removed following directories, because they're owned by sblim-testsuite (which is in Requires:) too:

/usr/share/sblim-testsuite/cim
/usr/share/sblim-testsuite/system
/usr/share/sblim-testsuite/system/linux

Comment 8 Roman Rakus 2009-10-20 13:48:19 UTC
Yeah, I mean /usr/share/sblim-testsuite with all subdirs ;) Nevertheless now it is ok

Comment 9 Vitezslav Crhonek 2009-10-20 14:01:09 UTC
New Package CVS Request
=======================
Package Name: sblim-gather
Short Description: SBLIM Performance Data Gatherer Base.
Owners: vcrhonek
Branches: F-10 F-11 F-12 EL-4 EL-5

Comment 10 Kevin Fenzi 2009-10-22 04:40:45 UTC
cvs done.