Bug 469291

- Source:
 - Please use 'Source0:
http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz' instead of
a link to a mirror
   https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net

what`s the lasted version ?

http://user-mode-linux.sourceforge.net/uml_utilities_20070815.tar.bz2
http://www.user-mode-linux.org/~blaisorblade/

Thanks for the pointers. The download sites are a complete mess. I hadn't even noticed there was a newer version until you pointed it out. It is only directly linked and not accessable via the sf.net downloads pages.

Spec URL: ftp://ftp.openswan.org/uml_utilities/uml_utilities.spec
SRPM URL:
ftp://ftp.openswan.org/uml_utilities/uml_utilities-20070815-1.fc9.src.rpm

* Sat Nov  1 2008 Paul Wouters <paul> - 20070815-1
- Was pointed to newer version of source at obscured location
- Hack out hardcoded stripping of binaries
- -D_FILE_OFFSET_BITS=64 no longer needed


rpmlint output:
uml_utilities.src:19: W: setup-not-quiet
uml_utilities.x86_64: E: setuid-binary /usr/bin/uml_net root 04755
uml_utilities.x86_64: E: non-standard-executable-perm /usr/bin/uml_net 04755
3 packages and 0 specfiles checked; 2 errors, 1 warnings.

I am not sure why setup is not quiet, since all it contains is:
%setup -n tools-%{ver}

which only untars the source without an error.

try

%setup -q -n tools-%{ver}

the Source0 is very strange, looks like jdike and blaisorblade is not using sourceforge to host files,  the best options is ask where are located the lasted version and what's the right address for downloading it.

what's the difference between 

this:

mylib=`echo %{_libdir} | sed "s/\/usr//"`
ln -s ..$mylib/uml/port-helper $RPM_BUILD_ROOT%{_bindir}/port-helper

and this :

ln -s  %{_libdir}/uml/port-helper $RPM_BUILD_ROOT%{_bindir}/port-helper

?

Re: #4: I'm now using the link that's most prominently linked as the "download it here" link. I also added -q, which indeed resolved the warning.

Re: #5: The difference is that I'm making a relative softlink, instead of an absolute one. eg a link to ../lib instead of /usr/lib

Spec URL: ftp://ftp.openswan.org/uml_utilities/uml_utilities.spec
SRPM URL:
ftp://ftp.openswan.org/uml_utilities/uml_utilities-20070815-2.fc9.src.rpm

* Sun Nov  2 2008 Paul Wouters <paul> - 20070815-2
- Added -q to setup

Anyone wants to pick up the review?

- RPM_OPT_FLAGS are not honoured:
https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags
E.g.:

cc -g -Wall -DTUNTAP   -c -o ethertap.o ethertap.c

- It does not build here, the Makefile of humsify contains:

install -o 0755 $(BIN) $(DESTDIR)$(BIN_DIR)

The "-o 0755" should probably be "-m 0755", which then can be omitted, because it is the default mode used by install.

Please make sure that the package builds before submitting it for review. You can use:

koji build --scratch dist-f11 *.src.rpm

To create a scratch build of the package on koji to verify that it builds.

Please remove the "NotReady" from the Whiteboard once you submitted a SRPM that does at least build.

I'll check the things you mentioned. And of course, it built fine for me. I'm using my own package on our dev servers :P

Based on Pauls work I've created an updated package which
addresses all mentioned issues:

- build problem
- RPM_OPT_FLAGS not honored

Spec URL: http://www-user.tu-chemnitz.de/~tiwi/uml_utilities-20070815-3.fc10.src.rpm
SRPM URL: http://www-user.tu-chemnitz.de/~tiwi/uml_utilities.spec

The package builds successfully in F10 and F11 on the 4 default architectures:
https://koji.fedoraproject.org/koji/taskinfo?taskID=1128542
https://koji.fedoraproject.org/koji/taskinfo?taskID=1128537

I'm looking forward to the next review cycle. It would be great if the package
could be included into Fedora soon.

I confirmed the package still works for me on x86_64. rpmlint is still fairly quiet:
uml_utilities.x86_64: E: setuid-binary /usr/bin/uml_net root 04755
uml_utilities.x86_64: E: non-standard-executable-perm /usr/bin/uml_net 04755
2 packages and 0 specfiles checked; 2 errors, 0 warnings.

Thanks for your work Christian! Let's hope we can get this into Fedora soon!

(In reply to comment #11)
> I confirmed the package still works for me on x86_64. rpmlint is still fairly
> quiet:
> uml_utilities.x86_64: E: setuid-binary /usr/bin/uml_net root 04755
> uml_utilities.x86_64: E: non-standard-executable-perm /usr/bin/uml_net 04755
> 2 packages and 0 specfiles checked; 2 errors, 0 warnings.
> 
> Thanks for your work Christian! Let's hope we can get this into Fedora soon!

uml_net requires suid bit to work , so there erros can be ignored.

%define ver    20070815

Please don't do this. Just put that in Version: and use %{version}. It will simplify the spec.

Also, the license tag is wrong. All of the code simply says "GPL", so the tag should be : License: GPL+

See: http://fedoraproject.org/wiki/Licensing/FAQ#How_do_I_figure_out_what_version_of_the_GPL.2FLGPL_my_package_is_under.3F

Also, it looks like the Source0 url is wrong, it should be:

http://user-mode-linux.sourceforge.net/%{name}_%{version}.tar.bz2

And... ncurses-devel is a Requires of readline-devel, so you shouldn't need to BuildRequires it.

Aside from that, everything looks fine. I'll finish the review, but please show me a finished package before I can flip the approved flag.

== Review ==
Good:

- rpmlint checks return:
uml_utilities.x86_64: E: setuid-binary /usr/bin/uml_net root 04755
uml_utilities.x86_64: E: non-standard-executable-perm /usr/bin/uml_net 04755
Safe to ignore.
- package meets naming guidelines
- package meets packaging guidelines
- license (GPL+) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream (4e10de8e0f5bf681fa295572009518b77fd8a1dd)
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

Thanks for the review!

(In reply to comment #13)
> Please don't do this. Just put that in Version: and use %{version}. It will
> simplify the spec.

Fixed.
 
> Also, the license tag is wrong. All of the code simply says "GPL", so the tag
> should be : License: GPL+

Fixed.

> Also, it looks like the Source0 url is wrong, it should be:
> http://user-mode-linux.sourceforge.net/%{name}_%{version}.tar.bz2

Fixed,
spectool -g SPECS/uml_utilities.spec
works fine now, sha1sum: 4e10de8e0f5bf681fa295572009518b77fd8a1dd

> And... ncurses-devel is a Requires of readline-devel, so you shouldn't need to
> BuildRequires it.

Fixed. Package builds fine locally using mock and for F10 and F11:

https://koji.fedoraproject.org/koji/taskinfo?taskID=1206294
https://koji.fedoraproject.org/koji/taskinfo?taskID=1206307

> Aside from that, everything looks fine. I'll finish the review, but please show
> me a finished package before I can flip the approved flag.

I've uploaded the new packages:

Spec URL:
http://www-user.tu-chemnitz.de/~tiwi/uml_utilities-20070815-4.fc10.src.rpm
SRPM URL: http://www-user.tu-chemnitz.de/~tiwi/uml_utilities.spec

Looks good, APPROVED.

New Package CVS Request
=======================
Package Name: uml_utilities
Short Description: Utilities for user-mode linux kernel
Owners: pwouters
Branches: EL-5, F-9, F-10
InitialCC:

cvs done.

uml_utilities-20070815-4.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/uml_utilities-20070815-4.fc10

uml_utilities-20070815-4.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/uml_utilities-20070815-4.fc9

Thanks everyone. Packages build

Except for EL-5, as it seems fuse is not enabled for EL-5 (though the package exists in EL-5, apparently there is no kernel support and therefor userland is not build, and our build fails with a missing fuse-devel dependancy)

uml_utilities-20070815-4.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

uml_utilities-20070815-5.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/uml_utilities-20070815-5.fc9

uml_utilities-20070815-5.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.