Bug 469569
| Summary: | Review Request: latex2rtf - LaTeX to RTF converter that handles equations, figures, and cross-references | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Susi Lehtola <susi.lehtola> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | j:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.9.19-5.fc10 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-03-25 16:03:55 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Susi Lehtola
2008-11-02 18:04:20 UTC
Were you going to address those rpmlint complaints? The first does seem to be bogus, the second should be fixed, shouldn't it? I mean, it's nice that you post the rpmlint output, but that only means that you know there are issues to be addressed, and I'd have to bring them up at review anyway. By the way, if you pass -i to sed it will edit the file in place or make a backup for you. (In reply to comment #1) > Were you going to address those rpmlint complaints? > > The first does seem to be bogus, the second should be fixed, shouldn't it? I > mean, it's nice that you post the rpmlint output, but that only means that you > know there are issues to be addressed, and I'd have to bring them up at review > anyway. No, I'm not going to address them: the second one is bogus, too, since it's a config file, not a script that causes the error. I do understand that it's a config file; the problem is that it's executable. Is there some reason that someone might ever want to execute it? Yeah, right. I don't think so; I removed the exec bit for now. Rpmlint output is now clean. Spec URL: http://theory.physics.helsinki.fi/~jzlehtol/rpms/latex2rtf.spec SRPM URL: http://theory.physics.helsinki.fi/~jzlehtol/rpms/latex2rtf-1.9.19-2.fc10.src.rpm Yes, this builds fine and rpmlint is silent. The Source0: URL doesn't seem to be correct. I believe you need to remove the "-unix" from the URL; it seems to work after that. You can use "spectool -g *spec" to test your source URLs. There's a copy of the GPL in doc/copying.txt that needs to be included in the package. There is a test suite included; a simple "make check" will run it. It requires build deps on texlive-latex and ImageMagick to run, but it doesn't actually complete. I don't know quite enough about TeX to understand why, though. I think it's worth looking into. * source files match upstream. sha256sum: bcdcd08b0211a05d3de03e9c8bdc80ddc5b6f16e53bab9ba86842368b37fa470 latex2rtf-1.9.19.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. X license text not included in package. * latest version is being packaged. * BuildRequires are proper (none). * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: latex2rtf = 1.9.19-2.fc11 latex2rtf(x86-64) = 1.9.19-2.fc11 = /bin/sh ImageMagick info X %check is not present, but there's a test suite in the source. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * scriptlets are OK (texinfo installation). * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. I had a look at the make check thing, but couldn't make it work. It seems to fail in two errors: ! LaTeX Error: File `html.sty' not found. ! LaTeX Error: Environment latexonly undefined. The latter error is probably caused by the first one, the missing style file. I have contacted upstream about this. For the time being, I don't put the check phase in the spec file. Fixed the others, though http://theory.physics.helsinki.fi/~jzlehtol/rpms/latex2rtf.spec http://theory.physics.helsinki.fi/~jzlehtol/rpms/latex2rtf-1.9.19-3.fc10.src.rpm Seems to be a permissions problem with the second link; I get "403 Forbidden". Sorry, should work now. Okay, got a reply from upstream: latex2html is the package that provides html.sty. Make check works now. http://theory.physics.helsinki.fi/~jzlehtol/rpms/latex2rtf.spec http://theory.physics.helsinki.fi/~jzlehtol/rpms/latex2rtf-1.9.19-4.fc10.src.rpm The source URL is correct now, the copying.txt file is included and the tests are run (and seem to complete successfully). Looks good to me. APPROVED Thanks for the review. New Package CVS Request ======================= Package Name: latex2rtf Short Description: LaTeX to RTF converter that handles equations, figures, and cross-references Owners: jussilehtola Branches: F-9 F-10 EL-5 InitialCC: cvs done. latex2rtf-1.9.19-5.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/latex2rtf-1.9.19-5.fc9 latex2rtf-1.9.19-5.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/latex2rtf-1.9.19-5.fc10 latex2rtf-1.9.19-5.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. latex2rtf-1.9.19-5.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. |