Bug 469673
| Summary: | Review request: perl-File-ShareDir-PAR - same functionality as File::ShareDir with PAR support | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Marcela Mašláňová <mmaslano> |
| Component: | Package Review | Assignee: | Stepan Kasal <kasal> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, kasal, notting |
| Target Milestone: | --- | Flags: | kasal:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-11-24 08:14:20 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Marcela Mašláňová
2008-11-03 13:10:56 UTC
We have scripts that parse these review requests. I ask again: please use the template or at least use the same format as other review tickets. Jason, I suppose you mean https://bugzilla.redhat.com/enter_bug.cgi?product=Fedora&format=extras-review right? Yes, or simply use the same format. Isn't the goal to have the packages reviewed quickly? I can't imagine why someone would want to differ needlessly, since it only complicates things for any automated processes we might have and thus slows things down. OK source files match upstream:
sha256sum: 1f528cd3fe2086b14f2992c4525a5cd697fb53c7cc8505bf5adeb78793e40b18
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK build root is correct.
OK license field matches the actual license.
OK license is open source-compatible.
OK license text included in package.
OK latest version is being packaged.
OK BuildRequires are proper.
OK %clean is present.
OK package builds in mock.
OK package installs properly.
OK no debuginfo package
OK rpmlint is silent.
BAD final provides and requires are sane -- see below
OK %check is present and all tests pass:
t/01_compile........ok
t/02_without_par....ok
t/03_with_par.......ok
All tests successful.
Files=3, Tests=60, 2 wallclock secs
Result: PASS
OK no shared libraries
OK owns the directories it creates.
BAD owns directories created by perl-File-ShareDir; please replace
%{perl_vendorlib}/*
with
%{perl_vendorlib}/File/ShareDir
%{perl_vendorlib}/auto/share/*/File-ShareDir-PAR
OK no duplicates in %files.
OK file permissions are appropriate.
OK no scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers. no pkgconfig files. no libtool .la droppings.
OK no desktop files
There are three redundant manual requires:
Requires: perl(Class::Inspector) >= 1.12
Requires: perl(File::ShareDir)
Requires: perl(Params::Util) >= 0.07
But all there requires are also detected automatically.
To add the version requirements, I suggest to patch PAR.rpm this way:
sed -i "
s/^use Params::Util *'/use Params::Util 0.07 '/
s/^use Class::Inspector *()/use Class::Inspector 1.12 ()/
" lib/File/ShareDir/PAR.pm
Please remember to set the fedora-review flag when you're reviewing a package. Please see new version http://mmaslano.fedorapeople.org/perl-File-ShareDir-PAR/perl-File-ShareDir-PAR-0.02-2.fc10.src.rpm http://mmaslano.fedorapeople.org/perl-File-ShareDir-PAR/perl-File-ShareDir-PAR.spec I apologize for wrong format. I was using what firefox offers in history :( The above changes has been incorporated, except the sed command patching File/ShareDir/PAR.pm, which really belongs upstream, not to the patch. APPROVED New Package CVS Request ======================= Package Name: perl-File-ShareDir-PAR Short Description: same functionality as File::ShareDir (compatible with PAR) Owners: mmaslano Branches: devel, F-10 InitialCC: fedora-perl-devel-list cvs done. |