Bug 469750 (perl-Term-Size)

Summary: Review Request: perl-Term-Size - Simple way to get terminal size
Product: [Fedora] Fedora Reporter: Chris Weyl <cweyl>
Component: Package ReviewAssignee: Parag AN(पराग) <panemade>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting, panemade, psabata
Target Milestone: ---Flags: panemade: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
URL: http://search.cpan.org/dist/Term-Size
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-11-06 04:25:18 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Chris Weyl 2008-11-03 21:00:37 UTC
Spec URL: http://fedorapeople.org/~cweyl/review/perl-Term-Size.spec
SRPM URL: http://fedorapeople.org/~cweyl/review/perl-Term-Size-0.2-1.fc9.src.rpm

Description:
*Term::Size* is a Perl module which provides a straightforward way to
retrieve the terminal size.

Both functions take an optional filehandle argument, which defaults to
'*STDIN{IO}'. They both return a list of two values, which are the current
width and height, respectively, of the terminal associated with the
specified filehandle.

'Term::Size::chars' returns the size in units of characters, whereas
'Term::Size::pixels' uses units of pixels.


Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=916588

Comment 1 Parag AN(पराग) 2008-11-04 10:21:43 UTC
Review:
+ package builds in mock (rawhide i386).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=916867
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
982b5df8351e7654a42b7bffc0bf1d57  Term-Size-0.2.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave None as they are not used.
+ Package  perl-Term-Size-0.2-1.fc10 =>
Provides: Size.so perl(Term::Size) = 0.2
Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) perl(AutoLoader) perl(Carp) perl(DynaLoader)
 perl(Exporter) perl(strict) perl(vars) rtld(GNU_HASH)
APPROVED.

Comment 2 Chris Weyl 2008-11-04 16:31:23 UTC
New Package CVS Request
=======================
Package Name: perl-Term-Size
Short Description: Simple way to get terminal size
Owners: cweyl
Branches: F-8 F-9 devel
InitialCC: perl-sig

Comment 3 Chris Weyl 2008-11-04 22:03:17 UTC
New Package CVS Request
=======================
Package Name: perl-Term-Size
Short Description: Simple way to get terminal size
Owners: cweyl
Branches: F-8 F-9 F-10 devel
InitialCC: perl-sig

Comment 4 Kevin Fenzi 2008-11-05 22:48:56 UTC
cvs done.

Comment 5 Petr Šabata 2013-10-14 04:11:59 UTC
Package Change Request
======================
Package Name: perl-Term-Size
New Branches: el6
Owners: georgiou
InitialCC: perl-sig

Comment 6 Gwyn Ciesla 2013-10-14 12:40:17 UTC
Git done (by process-git-requests).