Bug 469811

https://bugzilla.redhat.com/show_bug.cgi?id=469808 <--- depends on pstreams-devel

For whatever reason, it compiles on Fedora 9 i386, but complains when linking with jpeg.

[...]
g++ -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -pthread -I/usr/include/poppler   -DPOPPLER_VERSION=807  -DDJVULIBRE_BIN_PATH="\"/usr/bin\""    pdf2djvu.o compoppler.o debug.o config.o system.o sexpr.o quantizer.o -lpoppler -ldjvulibre -ljpeg -lpthread -lm      -o pdf2djvu 
/usr/bin/ld: cannot find -ljpeg
collect2: ld returned 1 exit status
make: *** [pdf2djvu] Error 1
error: Bad exit status from /var/tmp/rpm-tmp.61865 (%build)

Running `pkg-config --libs ddjvuapi' gives "-ldjvulibre -ljpeg -lpthread -lm".

I have libjpeg-6b-41.fc9.i386 installed.

(In reply to comment #2)
> For whatever reason, it compiles on Fedora 9 i386, but complains when linking
> with jpeg.
> 
> [...]
> g++ -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
> --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic
> -fasynchronous-unwind-tables -pthread -I/usr/include/poppler  
> -DPOPPLER_VERSION=807  -DDJVULIBRE_BIN_PATH="\"/usr/bin\""    pdf2djvu.o
> compoppler.o debug.o config.o system.o sexpr.o quantizer.o -lpoppler
> -ldjvulibre -ljpeg -lpthread -lm      -o pdf2djvu 
> /usr/bin/ld: cannot find -ljpeg
> collect2: ld returned 1 exit status
> make: *** [pdf2djvu] Error 1
> error: Bad exit status from /var/tmp/rpm-tmp.61865 (%build)
> 
> Running `pkg-config --libs ddjvuapi' gives "-ldjvulibre -ljpeg -lpthread -lm".
> 
> I have libjpeg-6b-41.fc9.i386 installed.

You need libjpeg-devel installed to be able to link with libjpeg.

MUST: Change patch1 to patch0.

MUST: License is GPLv2+, not GPLv2.

SHOULD: Please break BuildRequires one per line in alphabetized order.

MUST: Add libjpeg-devel to BR.

MUST: Modify install bit to

install -p -m 644 -D {doc,%{buildroot}%{_mandir}/man1}/pdf2djvu.1
install -p -m 755 -D {,%{buildroot}%{_bindir}/}pdf2djvu

to preserve time stamps.

SHOULD: Capitalize first letters of sentence in %changelog.


After you've corrected these I'll approve the package.

http://rakesh.fedorapeople.org/spec/pdf2djvu.spec
http://rakesh.fedorapeople.org/srpm/pdf2djvu-0.4.13-2.fc9.src.rpm

Updated.

Looks good, although you don't need

%defattr(644,root,root,755)

since the permissions are now set by install. Just use

%defattr(-,root,root,-)

You can do this upon import to CVS.

-----------------------------------
rpmlint output is clean.
Packaged according to Review Guidelines. 

The package is APPROVED.
-----------------------------------

(In reply to comment #6)
> Looks good, although you don't need
> 
> %defattr(644,root,root,755)
> 
> since the permissions are now set by install. Just use
> 
> %defattr(-,root,root,-)
> 
> You can do this upon import to CVS.

And you can also remove
%attr(755,root,root)
from bindir/* in the files section.

Thus, the new %files section should be

%defattr(-,root,root,-)
%{_bindir}/%{name}
%{_mandir}/man1/%{name}.1

Thanks - Will fix while importing.

New Package CVS Request
=======================
Package Name: pdf2djvu
Short Description: PDF to DjVu converter
Owners: rakesh
Branches: F-8 F-9 F-10
InitialCC:
Cvsextras Commits: yes

cvs done

Need to a fix in djvulibre to import. Reported:
https://bugzilla.redhat.com/show_bug.cgi?id=479385

Imported in Rawhide ... will build for F-10 and F-9 once djvulibre are in stable. Need to wait for a day before building.

Will not build for F9 or F10 as djvulibre has very deep devel pkg KDE deps which will need an unnecessary update as djvulibre updates soname.

Imported in rawhide.