Bug 469814

Created attachment 322403 [details]
Fix creation of empty debuginfo package.

The Makefile uses 'install -s' which strips the debug symbols from the binaries causing an empty debuginfo package to be created. The attached patch addresses this.

Thanks for patch.

Applied.

SPEC: http://rakesh.fedorapeople.org/spec/fuse-zip.spec
SRPM: http://rakesh.fedorapeople.org/srpm/fuse-zip-0.2.6-2.fc10.src.rpm

In %build I would also add LDFLAGS, because otherwise g++ is once called without these flags (g++  fuse-zip.o fileNode.o bigBuffer.o fuseZipData.o libZipWrapper.o -pthread -L/lib -lfuse -lrt -ldl   -lzip -lz   -o fuse-zip):


make %{?_smp_mflags} CXXFLAGS="$RPM_OPT_FLAGS" LDFLAGS="$RPM_OPT_FLAGS"



Instead of the sed and the DESTDIR you can better use this here in %install:
make install INSTALLPREFIX="$RPM_BUILD_ROOT/%{_prefix}"

DESTDIR is not used in the makefile, so you do not need to use it for make install.

http://rakesh.fedorapeople.org/spec/fuse-zip.spec
http://rakesh.fedorapeople.org/srpm/fuse-zip-0.2.6-3.fc10.src.rpm

Updated

http://koji.fedoraproject.org/koji/taskinfo?taskID=921071

[OK] rpmlint output: silent
[OK] Spec in %{name}.spec format

[OK] license allowed: GPLv3+
[OK] license matches shortname in License: tag
[OK] license in tarball and included in %doc: LICENSE

[OK] package is code or permissive content:

{OK} patches sent to upstream and commented
[OK] Source0 is a working URL
{N/A} Sourceforge URL is Source0: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz
<OK> SourceX / PatchY prefixed with %{name}
[OK] Source0 matches Upstream:
4b3c564d12226588c1564faa789b3608  fuse-zip-0.2.6.tar.gz

[OK] Package builds on all platforms:
http://koji.fedoraproject.org/koji/taskinfo?taskID=921071

[N/A] ExcludeArch bugs are filed and commented:
[OK] BuildRequires are complete (mock builds)
(OK) No file dependencies outside of /etc /bin /sbin /usr/bin /usr/sbin 

[N/A] %find_lang used for locales

[N/A] Every (sub)package containing libraries runs ldconfig
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
[N/A] .h (header) files are in -devel subpackage
[N/A] .a (static libraries) are in -static subpackage
[N/A] contains .pc (pkgconfig) files and has Requires: pkgconfig
(N/A) .pc files are in -devel subpackage
[N/A] contains .so.X(.Y) files and .so is in -devel
[N/A] -devel subpackage has Requires: %{name} = %{version}-%{release}
[N/A] .la files (libtool) are not included


[N/A] Has GUI and includes %{name}.desktop
[N/A] .desktop file installed with desktop-file-install in %install

[N/A] Prefix: /usr not used (not relocatable)

[OK] Owns all created directories
[OK] no duplicates in %files
[OK] %defattr(-,root,root,-) is in every %files section
[OK] Does not own files or dirs from other packages
[OK] included filenames are in UTF-8

[OK] %clean is rm -rf %{buildroot} or $RPM_BUILD_ROOT 
[OK] %install starts with rm -rf %{buildroot} or $RPM_BUILD_ROOT 

[OK] Consistent macro usage

[OK] large documentation is -doc subpackage
[OK] %doc does not affect runtime

{OK} no pre-built binaries (.a, .so*, executable)
{OK} well known BuildRoot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
{OK} PreReq not used
{OK} RPM_OPT_FLAGS honoured
{OK} Useful debuginfo generated
{OK} no duplication of system libraries
{OK} no rpath
{OK} Timestamps preserved with cp and install
{OK} Uses parallel make (%{?_smp_mflags})
{OK} Requires(pre,post) style notation not used
{OK} only writes to tmp /var/tmp $TMPDIR %{_tmppath} %{_builddir} (and %{buildroot} on %install and %clean)
{OK} no Conflicts
{OK} nothing installed in /srv
{OK} Changelog in allowed format

{OK} does not use Scriptlets
<N/A> Architecture independent packages have: BuildArch: noarch
<OK> Sane Provides: and Requires:

{OK} Follows Naming Guidelines

Please remove the INSTALL from %doc before importing this package into Fedora's CVS, because this file is not useful for users of Fedora. Everything else looks good, therefore this package is APPROVED.

Thanks - Yes I will remove that file.

New Package CVS Request
=======================
Package Name: fuse-zip
Short Description: Fuse-zip is a fs to navigate, extract, create and modify ZIP archives
Owners: rakesh
Branches: F-8 F-9 F-10
InitialCC:
Cvsextras Commits: yes

cvs done.

fuse-zip-0.2.6-4.fc8 has been submitted as an update for Fedora 8.
http://admin.fedoraproject.org/updates/fuse-zip-0.2.6-4.fc8

fuse-zip-0.2.6-4.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/fuse-zip-0.2.6-4.fc9

fuse-zip-0.2.6-4.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/fuse-zip-0.2.6-4.fc10

fuse-zip-0.2.6-5.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/fuse-zip-0.2.6-5.fc10

fuse-zip-0.2.6-5.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/fuse-zip-0.2.6-5.fc9

fuse-zip-0.2.6-5.fc8 has been submitted as an update for Fedora 8.
http://admin.fedoraproject.org/updates/fuse-zip-0.2.6-5.fc8

fuse-zip-0.2.6-5.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

fuse-zip-0.2.6-5.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.

fuse-zip-0.2.6-5.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.