Bug 469867
| Summary: | Cannot use arrow keys to move between cards in the main ESC screen | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Suzanne Hillman <shillman> | ||||
| Component: | esc | Assignee: | Jack Magne <jmagne> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Chandrasekar Kannan <ckannan> | ||||
| Severity: | low | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 6.0 | CC: | aakkiang, benl, ckannan, kwirth, mharmsen, ohegarty, rrelyea, shaines, syeghiay | ||||
| Target Milestone: | rc | Keywords: | Desktop | ||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | esc-1.1.0-19.el6 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2010-07-02 19:04:06 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Suzanne Hillman
2008-11-04 15:20:07 UTC
per smart card login team bug council, pushing to rhel6 Created attachment 386252 [details]
Proposed fix to this issue.
How To Test: 1. Start ESC. 2. Load 2 or more tokens into the computer and not the three lines in the listbox in the middle of the display, one for each token. 3. Use the tab key to negotiate to the the listbox containing the keys. 4. Use the up and down arrow keys and note that the current token selection changes each time. Also note that the previously highlighted token is no longer highlighted. 5. Try the above with one key to make sure that nothing strange happens. 6. Do the same for the case where there are no keys present. 7. Make sure that the tabbing functionality between the other buttons and controls still works as expected. attachment (id=386252) +mharmsen /cvs/dirsec/esc/src/app/xul/esc/chrome/content/esc/ESC.js,v <-- ESC.js new revision: 1.27; previous revision: 1.26 done Fix in esc-1.1.0-14.el6. Quick patch to fix this: Last line also resolves https://bugzilla.redhat.com/show_bug.cgi?id=556657 diff -r1.28 ESC.js 1812a1813 > list.selectItem(gCurrentSelectedRow); 1817c1818 < olditem = list.getItemAtIndex(0); --- > olditem = list.getItemAtIndex(0); 1828c1829 < } --- > } 1840c1841 < if(newitem) --- > if(newitem) 2398a2400 > DisableItem(menu_enroll); Comment #11: +mharmsen cvs commit -m "Further fix for #469867 - Cannot use arrow keys to move between cards in the main ESC screen." cvs commit: Examining . Enter passphrase for key '/home/jmagne/.ssh/id_rsa': Checking in ESC.js; /cvs/dirsec/esc/src/app/xul/esc/chrome/content/esc/ESC.js,v <-- ESC.js new revision: 1.29; previous revision: 1.28 done Running syncmail... Mailing relnotes... ...syncmail done. Running syncmail... Mailing cvsdirsec... ...syncmail done. Proposed simple fix for the minor issue in the last statement.
diff -up ./esc/src/app/xul/esc/chrome/content/esc/ESC.js.fix13 ./esc/src/app/xul/esc/chrome/content/esc/ESC.js
--- ./esc/src/app/xul/esc/chrome/content/esc/ESC.js.fix13 2010-03-30 11:47:05.869207316 -0700
+++ ./esc/src/app/xul/esc/chrome/content/esc/ESC.js 2010-03-30 11:47:34.344515684 -0700
@@ -1862,6 +1862,8 @@ function InitializeAdminBindingList()
window.setTimeout('ShowWindow()',250);
+ list.focus();
+
}
//Window related functions
Comment #19 +mharmsen cvs commit -m "Simple refinement to fix of #469867, Cannot use arrow keys to move between cards in the main ESC screen." ESC.js Checking in ESC.js; /cvs/dirsec/esc/src/app/xul/esc/chrome/content/esc/ESC.js,v <-- ESC.js new revision: 1.31; previous revision: 1.30 done Running syncmail... Mailing relnotes... ...syncmail done. Running syncmail... Mailing cvsdirsec... ...syncmail done. Another refinement to this fix:
diff -up ./esc/src/app/xul/esc/chrome/content/esc/ESC.js.fix14 ./esc/src/app/xul/esc/chrome/content/esc/ESC.js
--- ./esc/src/app/xul/esc/chrome/content/esc/ESC.js.fix14 2010-04-06 14:44:43.957811579 -0700
+++ ./esc/src/app/xul/esc/chrome/content/esc/ESC.js 2010-04-06 14:45:37.633698549 -0700
@@ -1841,6 +1841,15 @@ function AdminKeyPressHandler(evt)
if(newitem)
newitem.click();
}
+
+ var item = null;
+ for( i = 0; i < list.getRowCount(); i ++) {
+ item = list.getItemAtIndex(i);
+
+ if(item && item != gCurrentSelectedRow) {
+ item.setAttribute("class","UnSelectedRow");
+ }
+ }
}
function InitializeAdminBindingList()
Comment #24 +mharmsen Checking in ESC.js; /cvs/dirsec/esc/src/app/xul/esc/chrome/content/esc/ESC.js,v <-- ESC.js new revision: 1.32; previous revision: 1.31 done Running syncmail... Mailing relnotes... ...syncmail done. Running syncmail... Mailing cvsdirsec... ...syncmail done. Build 19 should address the above cosmetic issue reported when 3 keys are used. With esc build 19, tried moving between cards with 2 and 3 tokens, it works fine. Marking the bug verified. Red Hat Enterprise Linux Beta 2 is now available and should resolve the problem described in this bug report. This report is therefore being closed with a resolution of CURRENTRELEASE. You may reopen this bug report if the solution does not work for you. |