Bug 469911

Summary: filesystem test quietly fails
Product: [Fedora] Fedora Reporter: Daniel Qarras <dqarras>
Component: sectoolAssignee: Daniel Kopeček <dkopecek>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: 10CC: dkopecek, pvrabec
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-01-07 09:30:12 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
filesystem test wrapper none

Description Daniel Qarras 2008-11-04 18:06:35 UTC
Description of problem:
root@localhost:~# sectool --hint --level 5 --run filesystem --debug
filesystem ->
    filesystem: FAIL

This is on a system with SELinux disabled.

Comment 1 Daniel Kopeček 2008-11-18 14:23:26 UTC
Fixed in git:
 - added missing test_exit messages
 - don't exit if lstat(path) fails

The reported problem was probably caused by some file that the filesystem test was unable to lstat even with root privileges. This behavior was changed. The test now prints a warning message if this happens and continues.

Comment 2 Fedora Update System 2008-11-24 10:45:29 UTC
sectool-0.9.2-1 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/sectool-0.9.2-1

Comment 3 Bug Zapper 2008-11-26 04:45:38 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 10 development cycle.
Changing version to '10'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 4 Fedora Update System 2008-11-26 06:16:20 UTC
sectool-0.9.2-1 has been pushed to the Fedora 10 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update sectool'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/f10/FEDORA-2008-10272

Comment 5 Daniel Qarras 2008-11-26 22:59:33 UTC
Still seeing the same error when SELinux is disabled:

root@localhost:~# sectool --hint --level 3 --run filesystem --debug
filesystem ->
    filesystem: FAIL

Comment 6 Daniel Kopeček 2008-11-27 10:29:45 UTC
(In reply to comment #5)
> Still seeing the same error when SELinux is disabled:
> 
> root@localhost:~# sectool --hint --level 3 --run filesystem --debug
> filesystem ->
>     filesystem: FAIL

Sorry for that. I forgot to fix something on a different place :] New update should be available later today.

Comment 7 Daniel Kopeček 2008-11-27 22:37:21 UTC
Created attachment 324923 [details]
filesystem test wrapper

Could you please run the attached script on your machine? You should then see the failure reason. Unfortunately, the sectool update won't be available today.

Comment 8 Daniel Qarras 2008-11-27 23:44:28 UTC
Sure, no problem, please the output below:

root@localhost:~# rpm -q sectool
sectool-0.9.2-1.i386
root@localhost:~# rpm -V sectool
root@localhost:~# mount
/dev/sda3 on / type ext3 (rw,noatime,nodiratime)
/proc on /proc type proc (rw)
sysfs on /sys type sysfs (rw)
devpts on /dev/pts type devpts (rw,gid=5,mode=620)
tmpfs on /dev/shm type tmpfs (rw)
none on /proc/sys/fs/binfmt_misc type binfmt_misc (rw)
gvfs-fuse-daemon on /home/testuser/.gvfs type fuse.gvfs-fuse-daemon (rw,nosuid,nodev,user=testuser)
root@localhost:~# sh ./run-filesystem.sh
filesystem: filesystem.c:344: islocal: Assertion `DEVid_count > 1' failed.
./run-filesystem.sh: line 53:  3387 Aborted                 /usr/share/sectool/tests/filesystem
zsh: exit 134   sh ./run-filesystem.sh
root@localhost:~# 

Unfortunately, I didn't become any wiser after reading the error message :)

Comment 9 Daniel Kopeček 2008-11-28 00:07:17 UTC
(In reply to comment #8)
> root@localhost:~# sh ./run-filesystem.sh
> filesystem: filesystem.c:344: islocal: Assertion `DEVid_count > 1' failed.

Ah... This is the problem. Wrong assert :] It should be DEVid_count >= 1 (or > 0). I've fixed it in git.

Thanks

Comment 10 Fedora Update System 2008-12-01 23:28:20 UTC
sectool-0.9.2-2 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/sectool-0.9.2-2

Comment 11 Fedora Update System 2008-12-03 01:25:44 UTC
sectool-0.9.2-2 has been pushed to the Fedora 10 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update sectool'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2008-10649

Comment 12 Daniel Qarras 2008-12-03 17:10:18 UTC
Yep, now working all ok.

Comment 13 Fedora Update System 2009-01-07 09:29:54 UTC
sectool-0.9.2-2 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.