Bug 469927

Summary: cxgb3: allow LRO settings through ethtool
Product: Red Hat Enterprise Linux 5 Reporter: Divy Le Ray <divy>
Component: kernelAssignee: Andy Gospodarek <agospoda>
Status: CLOSED NOTABUG QA Contact: Martin Jenner <mjenner>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.3CC: peterm
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-11-07 19:16:30 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Divy Le Ray 2008-11-04 19:29:47 UTC
The cxgb3 driver supports LRO. It is however not controllable through ethtool.
The following patch allows ethtool to control LRO settings for cxgb3.

It has been committed to upstream kernel.org:
http://git.kernel.org/?p=linux/kernel/git/davem/net-next-2.6.git;a=commitdiff;h=04ecb07241d8731b16490f10bec6ccedf5cfc792

Cheers,
Divy

Comment 1 Andy Gospodarek 2008-11-05 21:59:11 UTC
We don't have the kernel bits (set_flags and get_flags) to make this happen, so I'm not sure this patch offers much to us, right?

Comment 2 Divy Le Ray 2008-11-05 22:03:57 UTC
You're right. This patch won't help without the updated ethtool code.
I guess we can close this.

Cheers,
Divy

Comment 3 Andy Gospodarek 2008-11-07 02:05:47 UTC
My test kernels have been updated to include a patch for this bugzilla.

http://people.redhat.com/agospoda/#rhel5

Please test them and report back your results.

Comment 4 Andy Gospodarek 2008-11-07 19:16:30 UTC
My scripts automagically added comment #3 since I had originally backported the fix to rhel5 and added to my git tree just in case.  It's really not needed for 5.3 however since it doesn't do anything.  Closing out.