Bug 469933

Summary: text-mode network activation dialog has incorrect focus.
Product: [Fedora] Fedora Reporter: James Laska <jlaska>
Component: anacondaAssignee: David Cantrell <dcantrell>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: anaconda-maint-list, dcantrell, jturner
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard: NEEDSRETESTING
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-11-08 00:11:57 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 469046    
Attachments:
Description Flags
Screenshot none

Description James Laska 2008-11-04 19:53:56 UTC
Created attachment 322473 [details]
Screenshot

Description of problem:

text-mode network activation dialog has incorrect focus.  The static IP fields should not be edit-able when [*] DHCP is selected.

Version-Release number of selected component (if applicable):
anaconda-11.4.1.54-1

How reproducible:
100%

Steps to Reproduce:
1. Boot DVD into rescue-mode
2. Request to activate network
  
Actual results:

See attached graphical screenshot (or ascii art below).  

Even though [*] DHCP is selected, I can still add/modify the static IP network settings.

     ┌───────────────────┤ Enable network interface ├────────────────────┐
     │                                                                   │
     │ This requires that you have an active network connection during   │
     │ the installation process.  Please configure a network interface.  │
     │                                                                   │      
     │  [ ] eth0 - Realtek Semiconductor Co., Ltd. RTL-8139/8139C/813 ↑  │      
     │                                                                ▮  │      
     │                                                                ↓  │      
     │                                                                   │      
     │ [*] Use dynamic IP configuration (DHCP)                           │      
     │ [*] Enable IPv4 support                                           │      
     │ IPv4 Address: ____________________/____________________           │      
     │ Gateway: ____________________  Nameserver: ____________________   │      
     │             ┌────┐                          ┌──────┐              │      
     │             │ OK │                          │ Back │              │      
     │             └────┘                          └──────┘              │
     │                                                                   │
     │                                                                   │
     └───────────────────────────────────────────────────────────────────┘

Expected results:

With [*] DHCP select, the static IP text fields should not be edit-able.

Additional info:

Comment 1 David Cantrell 2008-11-04 23:21:16 UTC
Durrrrhhhhh.....

diff --git a/textw/netconfig_text.py b/textw/netconfig_text.py
index 433f5d8..c5aba62 100644
--- a/textw/netconfig_text.py
+++ b/textw/netconfig_text.py
@@ -173,6 +173,7 @@ class NetworkConfiguratorText:
         # Call these functions to set initial UI state.
         self._ipv4Toggled()
         #self._ipv6Toggled()
+        self._dhcpToggled()
 
         netdevs = self.anaconda.id.network.available()

Comment 2 David Cantrell 2008-11-05 20:42:47 UTC
Will be fixed in anaconda-11.4.1.56-1.

Comment 3 Jesse Keating 2008-11-07 22:50:28 UTC
This will be in rawhide as of 20081108 or later.  Please re-test.

Comment 4 Jesse Keating 2008-11-08 00:11:57 UTC
I spun up a tree with this anaconda, confirmed fixed.