Bug 469957
Summary: | user.setDetails (and getDetails) uses 'first_names' as key. | ||
---|---|---|---|
Product: | Red Hat Satellite 5 | Reporter: | Justin Sherrill <jsherril> |
Component: | API | Assignee: | Jay Dobies <jason.dobies> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | wes hayutin <whayutin> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 530 | CC: | jason.dobies, tlestach |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | sat530 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-09-10 19:53:53 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 456996 |
Description
Justin Sherrill
2008-11-04 21:44:22 UTC
Commit: 233c64b8e502fe85ed1a77730559078d32adcdb8 Tag: spacewalk-java-0.5.14-1 UserHandler.java, UserHandlerTest.java - Added map to translate the user submitted key into an internal key. The only real translation that happens in this is from first_name to first_names, to allow the user specified key to read correctly and then translate to our incorrect domain model usage. The pluralization of first name goes deep into our code; it's even that way on User. I didn't want to do such a major refactor now, but at the same time I wanted to get the API correct and prevent having to have an incompatible API later. This way, if we do refactor the internal naming in the future, the external facing APIs won't have to change. SVN Commit: r181460 user.setDetails - Updated test for API key name change Commit: 5712dd41a819b488081aafdcb605b55d1a3b6e5e Tag: spacewalk-0.5.14-1 UserHandler.java, UserHandlerTest.java - Changed getDetails to use first_name instead of plural (see above comment for explanation). SVN Commit: r181463 user.getDetails - Updated test for API key name change apiusere2KIkFS3IHRK5 bob, bill (normal user) sat.version=5.3.0 sat.api.version=10.0 proxy.version=5.1 client for 'http://grandprix.rhndev.redhat.com/rpc/api' - created logged in (admin/dog8code), token: '310x08259a0cc38284946a1886d149a39479' client for 'http://grandprix.rhndev.redhat.com/rpc/api' - created logged in (admin/dog8code), token: '311x1788823f15531f4d67880c108665b4ae' Processing method: user.create Having both keys: first_name and first_names in user.setDetails and user.getDetails. If setting both for user.setDetails., first_name has higher prio. :) Stage validated -> RELEASE_PENDING An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHEA-2009-1434.html |