Bug 469993
| Summary: | Review Request: perl-MooseX-Types-URI - URI related types and coercions for Moose | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, ppisar |
| Target Milestone: | --- | Flags: | j:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://search.cpan.org/dist/MooseX-Types-URI | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-12-07 05:23:43 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 469627, 470070 | ||
| Bug Blocks: | |||
|
Description
Chris Weyl
2008-11-05 04:28:38 UTC
There are needed requirements: perl(MooseX::Types::Path::Class), perl(URI::FromHash). Hmm, I don't seem to be setting dependson/blocked right via xmlrpc since 3.0. Hm? I mean we don't have perl(MooseX::Types::Path::Class) and perl(URI::FromHash) packages into Fedora. (In reply to comment #3) > Hm? I mean we don't have perl(MooseX::Types::Path::Class) and > perl(URI::FromHash) packages into Fedora. As of a couple days ago, we do -- note the two review bugs that were blocking this bug. http://koji.fedoraproject.org/koji/taskinfo?taskID=940190 I had intended to get to this earlier, but better late than never.
* source files match upstream. sha256sum:
a47ad01575d14ecf9d953a62ead043bb715afc0eed1c34549a65f925ca180be9
MooseX-Types-URI-0.01.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
perl(MooseX::Types::URI) = 0.01
perl-MooseX-Types-URI = 0.01-1.fc11
=
perl(:MODULE_COMPAT_5.10.0)
perl(Moose::Util::TypeConstraints)
perl(MooseX::Types)
perl(MooseX::Types::Path::Class)
perl(Scalar::Util)
perl(URI)
perl(URI::FromHash)
perl(URI::WithBase)
perl(URI::data)
perl(URI::file)
perl(namespace::clean)
perl(strict)
perl(warnings)
* %check is present and all tests pass:
All tests successful.
Files=1, Tests=51, 0 wallclock secs ( 0.01 usr 0.00 sys + 0.19 cusr 0.01
csys = 0.21 CPU)
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
APPROVED
New Package CVS Request ======================= Package Name: perl-MooseX-Types-URI Short Description: URI related types and coercions for Moose Owners: cweyl Branches: F-9 F-10 devel InitialCC: cvs done. Package Change Request ====================== Package Name: perl-MooseX-Types-URI New Branches: Owners: InitialCC: perl-sig Please add perl-sig user with watch* permissions only to all Fedora branches. Done. |