| Summary: | Review Request: rubygem-rack - Common API for connecting web frameworks, web servers and layers of software | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jeroen van Meeuwen <vanmeeuwen+fedora> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, steve.traylen |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-12-09 11:36:15 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | |||
| Bug Blocks: | 470696 | ||
|
Description
Jeroen van Meeuwen
2008-11-08 23:44:04 UTC
For 0.4.0-1
* ruby(abi) dependency
- Please check
https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Packaging_Guidelines
* Unused macro
- %ruby_sitelib does not to be used anywhere.
* Dependency
- Please check if all needed Requires are added properly.
! For example, lib/rack/handler/mongrel.rb contains
----------------------------------------------------------
1 require 'mongrel'
2 require 'stringio'
----------------------------------------------------------
So this file has "Requires: rubygem(mongrel)".
However I don't know if this file itself is just optional
or not.
Anyway please check if all dependencies are correctly added.
* %gemdir/bin
- I guess files under %gemdir/bin must be moved into
%_bindir (ref: rubygem-mongrel.spec)
(In reply to comment #1) > For 0.4.0-1 > > * ruby(abi) dependency > - Please check > https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Packaging_Guidelines > Stupid /me, I always somehow forget this one. Fixed. > * Unused macro > - %ruby_sitelib does not to be used anywhere. > Fixed. > * Dependency > - Please check if all needed Requires are added properly. > ! For example, lib/rack/handler/mongrel.rb contains > ---------------------------------------------------------- > 1 require 'mongrel' > 2 require 'stringio' > ---------------------------------------------------------- > So this file has "Requires: rubygem(mongrel)". > However I don't know if this file itself is just optional > or not. > Anyway please check if all dependencies are correctly added. > This is entirely optional, it is one of the handlers -rack can cope with (amongst others; fastcgi and webrick) > * %gemdir/bin > - I guess files under %gemdir/bin must be moved into > %_bindir (ref: rubygem-mongrel.spec) Fixed. New SPEC: http://www.kanarip.com/custom/SPECS/rubygem-rack.spec New SRPM: http://www.kanarip.com/custom/f9/SRPMS/rubygem-rack-0.4.0-2.fc9.src.rpm Well,
* In comments and %changelog, please use %% instead of % so that macros
won't be expanded.
(Please fix this on Fedora CVS)
Other things are okay.
---------------------------------------------------------------------
This package (rubygem-rack) is APPROVED by mtasaka
---------------------------------------------------------------------
ping? ping again? Sorry this one has slipped through the cracks; I've resolved the %% issue now ;-) New Package CVS Request ======================= Package Name: rubygem-rack Short Description: Common API for connecting web frameworks, web servers and layers of software Owners: kanarip Branches: EL-4 EL-5 F-9 F-10 devel InitialCC: cvs done. For F-10/9 please submit push requests on bodhi: https://admin.fedoraproject.org/updates/ rubygem-rack-0.4.0-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/rubygem-rack-0.4.0-2.fc9 rubygem-rack-0.4.0-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/rubygem-rack-0.4.0-2.fc10 rubygem-rack-0.4.0-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. rubygem-rack-0.4.0-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: rubygem-rack New Branches: epel7 Owners: stevetraylen Git done (by process-git-requests). |