Bug 470714

Summary:	Inherit group tag from src.rpm if unspecified in a subpackage
Product:	[Fedora] Fedora	Reporter:	Nicolas Mailhot <nicolas.mailhot>
Component:	rpm	Assignee:	Jindrich Novy <jnovy>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	ffesti, jnovy, pknirsch, pmatilai
Target Milestone:	---	Keywords:	Reopened
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-02-16 17:36:09 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	446451

Description Nicolas Mailhot 2008-11-09 09:05:26 UTC

Description of problem:

When I create a package with many subpackages, they do not inherit the src.rpm Group tag if unspecified like other metadata (and rpmlint will complain if this tag is unspecified)

This forces packagers to repeat many times over the same group info (big problem for font set packages which have many subpackages ; each line of useless fluff makes them less maintenable).

And we don't even use this tag anymore for anything useful.

Please limit the pain and make one group tag per spec files sufficient.


Version-Release number of selected component (if applicable):

rpm-build-4.6.0-0.rc1.7.x86_64

Example problem spec
http://cvs.fedoraproject.org/viewvc/devel/dejavu-fonts/dejavu-fonts.spec?revision=1.89&view=markup

Note how the Group tag is about the only useless repetition that could not be factored out in every sub-package

Comment 1 Bug Zapper 2008-11-26 05:05:11 UTC

This bug appears to have been reported against 'rawhide' during the Fedora 10 development cycle.
Changing version to '10'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 2 Jon Stanley 2008-11-26 19:13:38 UTC

Fixing version to align with rawhide again.  Sorry for the noise.

Comment 3 Jindrich Novy 2009-01-13 08:32:13 UTC

Fixed upstream.

The group tag is not mandatory for a while now. But good practise is to define at least the group tag in the main package otherwise it is set to "Unspecified".

Group tag of the main package is inherited by subpackages if they haven't defined the group themselves. It applies from now on.

Comment 4 Nicolas Mailhot 2009-02-14 11:56:28 UTC

I've just tested it with 
rpm-4.6.0-2.fc11.x86_64

And subpackages are all set to "Unspecified" :(

Maybe your change assumes there is a main package with the same name as the srpm?

In my package all the subpackages have different names (but the srpm has the correct group tag)

Comment 5 Jindrich Novy 2009-02-14 14:23:59 UTC

Could you point me to src.rpm of your package?

Comment 6 Nicolas Mailhot 2009-02-14 15:07:45 UTC

(In reply to comment #5)
> Could you point me to src.rpm of your package?

Here it is
http://nim.fedorapeople.org/dejavu-fonts-2.28-5.fc11.src.rpm

Comment 7 Jindrich Novy 2009-02-15 17:44:25 UTC

The reason you are seeing this is that the patches for the group inheritance aren't in rawhide rpm yet. Only in upstream (basically base for rpm-4.7.0). Maybe we want to backport the patches to current Fedora so that you can use it.

Comment 8 Nicolas Mailhot 2009-02-15 17:55:07 UTC

Since F11 is seeing rpm changes all over the place is would be nice to have this one included to have a single big change at F11 time

Comment 9 Jindrich Novy 2009-02-16 17:36:09 UTC

The fix is now in backported to rawhide rpm-4.6.0-4.