Bug 470909
Summary: | Review Request: wt - C++ library and application server for developing web applications | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Lorenzo Villani <lorenzo> |
Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | denis.arnaud_fedora, fedora-package-review, giallu, notting, pertusus |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-07-30 12:43:26 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 201449 |
Description
Lorenzo Villani
2008-11-10 20:37:17 UTC
The description is too long, in my opinion. Please have a look at: http://fedoraproject.org/wiki/PackageMaintainers/Packaging_Tricks#Use_of_common_namespace > The description is too long, in my opinion. Going to cut it ASAP > Please have a look at: > http://fedoraproject.org/wiki/PackageMaintainers/Packaging_Tricks#Use_of_common_namespace You mean that the package name is too much generic/short? (webtoolkit would be better?) > %files > %defattr(-,root,root,-) > %doc LICENSE AUTHORS BUGS ReleaseNotes.html > %{_sysconfdir}/wt/wt_config.xml > %{_datadir}/Wt/resources/ The following directories are not included: %{_sysconfdir}/wt %{_datadir}/Wt Include the right directories recursively or use %dir attributes as appropriate. This is one of the MUST items you've quoted. > %files devel > %defattr(-,root,root,-) > %doc LICENSE AUTHORS BUGS Even if harddisk space is cheap, why duplicate these files, which are already found in the main pkg? Spec URL: http://fedorapeople.org/gitweb?p=arbiter/public_git/rpm.git;a=blob_plain;f=libs/wt/wt.spec;hb=HEAD SRPM URL: http://fedorapeople.org/~arbiter/srpm/wt-2.1.5-2.fc10.src.rpm * Sun Nov 23 2008 Lorenzo Villani <lvillani> - 2.1.5-2 - shorter description - own _includedir/Wt _sysconfdir/wt and _datadir/Wt directory (fix) - do not duplicate documentation files across packages SPEC URL: http://fedorapeople.org/gitweb?p=arbiter/public_git/rpm.git;a=blob_plain;f=wt/wt.spec;hb=HEAD SRPM URL: http://fedorapeople.org/~arbiter/fedora/10/x86_64/SRPM/wt-2.2.3-1.fc10.src.rpm * Mon Jan 26 2009 Lorenzo Villani <lvillani> - 2.2.3-1 - 2.2.3 SPEC URL: http://fedorapeople.org/gitweb?p=arbiter/public_git/rpm.git;a=blob_plain;f=wt/wt.spec;hb=HEAD SRPM URL: http://fedorapeople.org/~arbiter/fedora/10/x86_64/SRPM/wt-2.2.3-1.fc10.src.rpm * Mon Jan 26 2009 Lorenzo Villani <lvillani> - 2.2.3-1 - 2.2.3 SPEC URL: http://fedorapeople.org/gitweb?p=arbiter/public_git/rpm.git;a=blob_plain;f=wt/wt.spec;hb=HEAD SRPM URL: http://fedorapeople.org/~arbiter/fedora/10/x86_64/SRPM/wt-2.2.3-1.fc10.src.rpm * Mon Jan 26 2009 Lorenzo Villani <lvillani> - 2.2.3-1 - 2.2.3 Ehrm, sorry, RH's bugzilla was so slow to accept my request that I pushed the reload button a couple of times. Any reason why you're deviating from the recommended steps for cmake based projects? https://fedoraproject.org/wiki/Packaging:Cmake#Specfile_Usage More items to check: as said before the description is really too long and marketing oriented. I propose something like: === Wt (pronounced 'witty') is a C++ library and application server for developing and deploying web applications. A web application developed with Wt is written in only one compiled language (C++), from which the library generates the necessary HTML/XHTML, Javascript, CGI, SVG/VML/Canvas and AJAX code. === * The -devel subpackage needs to Require: its dependencies. * you are now adding files picking up the whole directories => no more need for explictly owning them with %dir; for example, one of: %dir %{_includedir}/Wt %{_includedir}/Wt is redundant * The library is GPLv2, but it has the OpenSSL exception, moreover some binaries are under different licenses; from the website: -The built-in httpd is based on an example of the asio C++ library, developed by Christopher M. Kohlhoff (Boost Software License). -Thread pool implementation from Philipp Henkel (threadpool; Boost Software License). -The Mini-XML 2.4 library by Michael Sweet (Mini-XML license , which is LGPL with some exceptions) Please check everything and compose a complete license field acoording to: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios * There is some doxygen documentation available, consider packaging it (probably in a -doc subpackage) SPEC URI: http://github.com/binaryhelix/specs/blob/ab62573a7843d1552daba06883ac52bd08dc6e49/wt/wt.spec SRPM URI: http://fedorapeople.org/~arbiter/wt/wt-2.2.3-2.fc10.src.rpm * Fri May 8 2009 Lorenzo Villani <lvillani> - 2.2.3-2 - Require dependencies in -devel subpackage - Drop redundant declarations in %%files - Add -doc subpackage - Fix License tag My interests shifted to my self-developed REST application framework and I don't need Wt packaged anymore in Fedora. NOTE: the .spec link and SRPM are broken. |