Bug 471035
| Summary: | Journal-comparing script is still pretty stupid | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Petr Muller <pmuller> | ||||
| Component: | beakerlib | Assignee: | Dalibor Pospíšil <dapospis> | ||||
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 26 | CC: | mkyral, ohudlick, qa-errata-list | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2017-08-24 20:11:29 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 555302 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Petr Muller
2008-11-11 14:33:23 UTC
Created attachment 341451 [details]
patch to ignore unmatched asserts
What about ignoring unmatched asserts and printing a [WARN]
message instead of a traceback? Patch included.
Good stuff as a first aid. Go ahead and check it in, please. We'll leave this bug open so we can rework the compare script to really do its job. pushed to git: http://git.fedorahosted.org/git/beaker.git?p=beaker.git;a=commitdiff;h=bcbd71692913c565a68aea30221a4b797d4e3b8e Then next main issue is that journal-compare always returns 0, thus making false PASSes even if some of the tests fail... # ./journal-compare.py ==== Actual compare ==== * Metrics * [PASS] PyStones0 (First 1.0, second 8.8, toleranced first 1.2) [FAIL] PyStones1 (First 1.0, second 8.8, toleranced first 1.2) ... # echo $? 0 This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle. Changing version to '19'. (As we did not run this process for some time, it could affect also pre-Fedora 19 development cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.) More information and reason for this action is here: https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora19 This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component. Is this tool currently used and/or supported? I am not able to find it in any package available. This message is a notice that Fedora 19 is now at end of life. Fedora has stopped maintaining and issuing updates for Fedora 19. It is Fedora's policy to close all bug reports from releases that are no longer maintained. Approximately 4 (four) weeks from now this bug will be closed as EOL if it remains open with a Fedora 'version' of '19'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 19 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. It's both in the tree and in the packages:
[beakerlib]$ ls src/python/journal-compare.py
src/python/journal-compare.py
[beakerlib]$ rpm -ql beakerlib | grep bin
/usr/bin/beakerlib-deja-summarize
/usr/bin/beakerlib-journalcmp
^^^^^^^^^^^^^^^^^^^^
/usr/bin/beakerlib-journalling
/usr/bin/beakerlib-lsb_release
/usr/bin/beakerlib-rlMemAvg
/usr/bin/beakerlib-rlMemPeak
/usr/bin/beakerlib-storage
/usr/bin/beakerlib-testwatcher
Do we want to maintain such tool? Does anyone use it? This bug appears to have been reported against 'rawhide' during the Fedora 23 development cycle. Changing version to '23'. (As we did not run this process for some time, it could affect also pre-Fedora 23 development cycle bugs. We are very sorry. It will help us with cleanup during Fedora 23 End Of Life. Thank you.) More information and reason for this action is here: https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora23 This message is a reminder that Fedora 23 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 23. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '23'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 23 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. This bug appears to have been reported against 'rawhide' during the Fedora 26 development cycle. Changing version to '26'. Given that last actual activity on this bug happened 8 years ago and noone complains about it not being fixed, I suggest the script can remain stupid until the end if its days and this bug can be CLOSED WONTFIX. |