Bug 471321
| Summary: | long append="..." causes yaboot to reject entire yaboot.conf (MAX_TOKEN too small) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Will Woods <wwoods> | ||||
| Component: | yaboot | Assignee: | David Woodhouse <dwmw2> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | dwmw2, pnasrat, rrakus | ||||
| Target Milestone: | --- | Keywords: | Patch | ||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2008-11-26 13:17:38 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
This bug appears to have been reported against 'rawhide' during the Fedora 10 development cycle. Changing version to '10'. More information and reason for this action is here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping Fixed in rawhide yaboot-1.3.14-7.fc11 yaboot-1.3.13-13.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/yaboot-1.3.13-13.fc9 yaboot-1.3.13-9.fc8 has been submitted as an update for Fedora 8. http://admin.fedoraproject.org/updates/yaboot-1.3.13-9.fc8 yaboot-1.3.13-9.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. yaboot-1.3.14-8.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/yaboot-1.3.14-8.fc10 yaboot-1.3.13-13.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. yaboot-1.3.14-8.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |
Created attachment 323398 [details] yaboot-1.3.14-bigger-max-token.patch yaboot's second/cfg.c has: #define MAX_TOKEN 200 When yaboot parses its config file, if it encounters a quoted string (like append="...") longer than MAX_TOKEN, it rejects the entire config. Typical preupgrade usage uses ~250 chars, which means preupgrade currently renders ppc systems unbootable without this patch. Suggest increasing MAX_TOKEN to.. let's say 511. cfg.c does "char buf[MAX_TOKEN+1]", and everyone loves powers of 2.