Bug 471335
| Summary: | Review Request: libgdbus - Library for simple D-Bus integration with GLib | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabian Affolter <mail> | ||||
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | fedora-package-review, notting, panemade | ||||
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2009-01-07 09:20:16 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Fabian Affolter
2008-11-13 01:04:38 UTC
Created attachment 325510 [details]
suggest to add doc files to -devel package
modified spec to add docs to -devel
Thanks Parag Here are the new files Spec URL: http://fab.fedorapeople.org/packages/SRPMS/libgdbus.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/libgdbus-0.2-2.fc9.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=983783 Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=983783 + rpmlint is silent for SRPM and for RPM. + source files match upstream url f51d19564bdf77af1c132c2a38643fe4 libgdbus-0.2.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + BuildRequires are proper. + Compiler flags used correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + gdbus.pc file present. + -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + ldconfig scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package libgdbus-0.2-2.fc10 -> Provides: libgdbus.so.0 Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libdbus-1.so.3 libgdbus.so.0 libglib-2.0.so.0 rtld(GNU_HASH) + Package libgdbus-devel-0.2-2.fc10 -> Provides: pkgconfig(gdbus) = 0.2 Requires: libgdbus.so.0 + Not a GUI application. APPROVED. Parag, thanks for the review. New Package CVS Request ======================= Package Name: libgdbus Short Description: Library for simple D-Bus integration with GLib Owners: fab Branches: F-9 F-10 InitialCC: cvs done. libgdbus-0.2-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/libgdbus-0.2-2.fc10 libgdbus-0.2-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/libgdbus-0.2-2.fc9 libgdbus-0.2-2.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update libgdbus'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2008-11307 libgdbus-0.2-2.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update libgdbus'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-11301 libgdbus-0.2-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. libgdbus-0.2-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. |