Bug 471703
| Summary: | RFE: new "make" target that does not use 98-100% CPU | ||
|---|---|---|---|
| Product: | [Community] Publican | Reporter: | Murray McAllister <mmcallis> |
| Component: | publican | Assignee: | Ruediger Landmann <rlandman+disabled> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Joshua Wulf <jwulf> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | 2.0 | CC: | ccurran, jfearn, lcarlon, mmcallis, publican-list, rlandman, vdanen |
| Target Milestone: | --- | Keywords: | Documentation |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.0 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-11-26 04:59:45 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Murray McAllister
2008-11-15 02:07:18 UTC
* "...does not have to be a new "make" target - ..." Doing anything about the performance really requires the make files to be rewritten in a proper programming language. This would take about 3 weeks to complete. One side affect of doing this would be that each books make file would need to be converted to a suitable configuration file. e.g. a conf, ini or xml file. Doing this would make the creation of a GUI, or integrating the build in an editing tool, easier. Why write a net configuration file when you can just parse the existing make file in new ways. Just write publican.pl which looks the same as make and has similar functionality to the existing make system. For example, the present system: make html-single-en-US Hypothetical new system: publican html-single-en-US And spit out errors like: "You're not in a publican books directory, you dolt!" "I can't find a Makefile" Or, similarly...
prepForPublican = do
wd ← liftIO $ getWorkingDirectory
conts ← liftIO $ getDirectoryContents wd >>= return ◦ filter (∉ [".", ".."])
env ← ask
state ← get
if lit_Makefile ∉ conts
then do
outLine $ msgNoBuildFile wd
retCode 1 fnNm
else do
mf ← parseMakefile `liftM` (liftIO $ readFile lit_Makefile)
put state
{ makefile = Just mf
, docLocation = lookup "XML_LANG" mf
, docName = (flip addExtension $ ".xml")
`liftM` (lookup "DOCNAME" mf)}
retCode 0 fnNm
where
fnNm = "prepForPublican"
msgNoBuildFile wd = docitErr ⧺ fnNm ⧺ ": "
⧺ "a Makefile does not not exist in the current working directory: " ⧺ wd
This is being addressed. Stay tuned until post docs.redhat.com rebase. This should be fixed in the BETA. Fixed in 1.0 I built a simple book[1] with the following results: Version 0.44 -- took 73 seconds and used between 60% and 70% CPU for most of that time, but used 92% CPU for the final stage of the build, once Saxon was called. Version 1.0 -- took 3 seconds, and CPU shot up to a maximum of 40% momentarily (less than a second). publican-1.2-0.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/publican-1.2-0.fc12 publican-1.2-0.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. publican-1.2-0.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |