Bug 471827
| Summary: | catalog should provide reviewers a way to change the "Shipping Information" status back to "No" | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Retired] Red Hat Hardware Certification Program | Reporter: | YangKun <ykun> | ||||
| Component: | Hardware Catalog | Assignee: | XINSUN <xisun> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 5.2 | CC: | rlandry | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | 5.3 (hwcert-3.2rh-20090129.0) | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2009-02-04 04:42:21 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Created attachment 326255 [details] patch fix: 1.Modify the file of bug/tam_ack.html.tmpl to display the "Shipping Information" status as follows: [% IF bug.reporter.login == user.login %] No <input type="radio" name="shipped_to_rh" value="0" checked onchange="shippingTextBox();"> Yes <input type="radio" name="shipped_to_rh" value="1" onchange="shippingTextBox(); document.changeform.shipping_info.focus();"> [% ELSIF bug.shipped_to_rh %] Yes <input type="hidden" name="shipped_to_rh" value="1"> [% ELSE %] No <input type="hidden" name="shipped_to_rh" value="0"> 2.Modify the file of process.cgi to add the values of "shipped_to_th" and "shipping_info" into database correctly. Test link is http://bugdev.devel.redhat.com/hwcert-xisun5/show.cgi?id=465648 Please review. Best Regards! Fuyan We need to add a hwcertlog item for this to record when things were changed and what they were changed to/from. IIRC this field is in the hwcert db so we won't be able to use the bz logging, we'll have to expand the hwcert logging. Test well and checked in, change to MODIFIED. |
Description of problem: One issue about the "Shipping Information:" field in our catalog now is: if someone miss filled this area by accident, the "Current Status:" will be changed to "Yes", and there's no way to change this status back to "No" again. Even when I tried to remove all the data in the "Shipping Information:" field and then "save changes", the catalog just replies with: --------------------------------------------------- Shipping Information Needed You must enter shipping information for this certification. Please press Back and try again. --------------------------------------------------- catalog should provide reviewers a way to change the "Shipping Information" status back to "No".