Bug 472027

Just to note here that this package was previously submitted in bug447367

Suggestion:-
   1) Good to modify onboard.desktop file line from 
Categories=GNOME;GTK;Accessibility;X-GNOME-PersonalSettings;
to
Categories=GNOME;GTK;Utility;Accessibility;

   This will make sure we have all onboard/onscreen virtual keyboards in same category

   2) This package built successfully by removing
       BuildRequires:  python-setuptools-devel
       BuildRequires:  gettext

   3) I think you don't need Requires: gnome-python2 not sure about that though.

ping

I'm working on this but it will take some more days because I'm not able to fix the .desktop file at the moment. 

Anyway, thanks for your inputs.

Created attachment 326105 [details]
modified onboard.desktop

Created attachment 326106 [details]
modified onboard-settings.desktop

Created attachment 326107 [details]
modified onboard.spec

Created attachment 326108 [details]
modified onboard.spec

(In reply to comment #2)
> Suggestion:-
>    1) Good to modify onboard.desktop file line from 
> Categories=GNOME;GTK;Accessibility;X-GNOME-PersonalSettings;
> to
> Categories=GNOME;GTK;Utility;Accessibility;
> 
>    This will make sure we have all onboard/onscreen virtual keyboards in same
> category

fixed.  For now I'm OK with the usage of your modified files.  In the trunk of onBoard are already .desktop files which will be shipped with the next release, I guess.

>    2) This package built successfully by removing
>        BuildRequires:  python-setuptools-devel

This is needed for the generation of the egg.  It's mentioned in the guidelines

>        BuildRequires:  gettext

I will leave it in place because as soon I'm able to integrate the translations it's needed.
 
>    3) I think you don't need Requires: gnome-python2 not sure about that
> though.

removed

Here are the new files:
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/onboard.spec
SRPM URL:
http://fab.fedorapeople.org/packages/SRPMS/onboard-0.91.2-3.fc9.src.rpm

+ is OK
- Needs work

Review:
+ package builds in mock.
 Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=998755
- rpmlint is silent for RPM. But Not for SRPM.
onboard.src: W: strange-permission onboard.spec 0666
==> easy to fix.

+ source files match upstream.
6e0dde122c50dcdfc27fe32b714edf3f  onboard-0.91.2.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Desktop files installed correctly.
+ Followed python guidelines.
+ GUI app.

Suggestions:-
  You can ask upstream to include/modify .desktop files as used in this package.

APPROVED.

Many thanks for the review.  The .desktop files are already present in the trunk of the upstream VCS.

New Package CVS Request
=======================
Package Name: onboard
Short Description: Simple on-screen Keyboard
Owners: fab
Branches: F-9 F-10
InitialCC:

(In reply to comment #11)
> Many thanks for the review.  The .desktop files are already present in the
> trunk of the upstream VCS.

you welcome. Here I mean upstream .desktop files are different than Fedora .desktop files now. So if you drop these .desktop files in next update for new upstream release in spec file then existing .desktop files in fedora will get overwritten.

see comment#2 suggestion 1.

Now, I get the point. I will get in touch with upstream to see if they are kind enough to change the .desktop files to our needs.

Thanks.

CVS Done

onboard-0.91.2-3.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/onboard-0.91.2-3.fc9

onboard-0.91.2-3.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/onboard-0.91.2-3.fc10

onboard-0.91.2-3.fc10 has been pushed to the Fedora 10 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update onboard'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2008-11426

onboard-0.91.2-3.fc9 has been pushed to the Fedora 9 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing-newkey update onboard'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-11448

onboard-0.91.2-3.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

onboard-0.91.2-3.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.