Bug 472274
| Summary: | Review Request: atari++ - Unix based emulator of the Atari eight bit computers | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dan Horák <dan> |
| Component: | Package Review | Assignee: | Miroslav Lichvar <mlichvar> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, herrold, mlichvar, notting |
| Target Milestone: | --- | Flags: | mlichvar:
fedora-review+
dennis: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-11-23 21:06:39 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Dan Horák
2008-11-19 18:57:18 UTC
- rpmlint output:
atari++.x86_64: W: file-not-utf8 /usr/share/doc/atari++-1.55/CREDITS
atari++.x86_64: W: invalid-license TPL
Not a blocker, but please convert also CREDITS in the spec.
TPL is a valid license.
- the package is named according to the Package Naming Guidelines
- the spec file name matches the base package %{name}
- the package meets the Packaging Guidelines
- the package is licensed with a Fedora approved license (TPL)
- the License field in the package spec file matches the actual license
- the file containing the text of the license(s) for the package is included in %doc
- the spec file is written in American English
- the spec file for the package is legible
- the source matches the upstream source
- all build dependencies are listed in BuildRequires
- the package does not contain any duplicate files in the %files listing
- permissions on files are set properly
- the package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT
- the package consistently uses macros
- the package contains code, or permissible content
- files included as %doc don't affect the runtime of the application
- the package does not own files or directories already owned by other packages
- at the beginning of %install, the package runs rm -rf $RPM_BUILD_ROOT
- all filenames in rpm packages are valid UTF-8
- the package builds in mock (at least on x86_64)
- the package functions as described
Approved.
New Package CVS Request ======================= Package Name: atari++ Short Description: Unix based emulator of the Atari eight bit computers Owners: sharkcz Branches: F-9 F-10 cvs done. Imported and built, thanks for the review. Package Change Request ====================== Package Name: atari++ New Branches: EL-5 Owners: sharkcz CVS Done |