Bug 472369

Summary: fence_ipmilan does not handle punctuation in password
Product: [Retired] Red Hat Cluster Suite Reporter: Jan Friesse <jfriesse>
Component: fenceAssignee: Jim Parsons <jparsons>
Status: CLOSED ERRATA QA Contact: Cluster QE <mspqa-list>
Severity: low Docs Contact:
Priority: low    
Version: 4CC: bkahn, bstevens, cfeist, cluster-maint, djansa, edamato, jfriesse, rmccabe
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-05-18 21:16:09 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 447964    
Bug Blocks:    

Description Jan Friesse 2008-11-20 14:43:56 UTC 
+++ This bug was initially created as a clone of Bug #447964 +++

Description of problem:
When using a password containing the '$' character, fence_ipmilan will not
connect to the IPMI node. If the ipmitool command is run with the -a option to
specify the same password interactively, it completes properly.
Passwords containing '+', '@', and '?' work correctly with fence_ipmilan.


Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1.Set a password on an IPMI node containing a '$' as well as  other characters
2.Set up a cluster with a fence device of type IPMI pointed at the previous node
3.Attempt to fence the node in Luci
  
Actual results:
Node remains up

Expected results:
Node should turn off, and then on

Additional info:

--- Additional comment from jfriesse on 2008-11-20 09:22:01 EDT ---

Created an attachment (id=324180)
Patch to fix problem

IPMI fence agent works by spawn a /bin/sh and ipmitool. If host name/password or any other command line argument included special shell characters (like $, ", ', ...) shell will try to substitute. This is not allowed behaviour and
this patch fix it.
Comment 4 errata-xmlrpc 2009-05-18 21:16:09 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2009-1050.html