Bug 472696 (vcards-daemon)
Summary: | Review Request: vcards-daemon - manage evolution contacts as vcards | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Alec Leamas <leamas.alec> |
Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, itamar, mtasaka, notting |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-07-10 18:08:06 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 201449 |
Description
Alec Leamas
2008-11-23 17:51:11 UTC
This is my second aubmission for approval; I need s sponsor. My attempts to make what's required for being sponsored are documented in bug 471575 This is my second submission for approval; I need s sponsor. My attempts to make what's required for being sponsored are documented in bug 471575 Some notes for 0.2-1.61: * Versioning / creating tarball - If you want to rebase source tarball on svn repository, please follow: * To create tarball: https://fedoraproject.org/wiki/Packaging/SourceURL#Using_Revision_Control * For versioning: https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Snapshot_packages * BR (BuildRequires) - This package does not build without "BR: cvs" http://koji.fedoraproject.org/koji/taskinfo?taskID=1374931 - I guess "BR: gettext-devel" can be changed to "BR: gettext" and "BR: subversion" is not needed (once the tarball is created) (koji scratch build succeeds) - When perl module related packages are needed for BR, please avoid to use direct name of the package but use virtual name which the needed rpm provides: https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides (i.e. change to "BuildRequires: perl(XML::Parser)" - "BR: glib2-devel" is redundant because gtk2-devel requires glib2-devel. * %configure usage - "--prefix=%{_prefix}" or so is not needed for %configure ! You can check what %configure actually does by $ rpm --eval %configure * desktop-file-utils usage - "desktop-file-validate" must be called for the files installed under %buildroot (i.e after "make install") * Keeping timestamps - Please consider to use ------------------------------------------------------------------ make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" ------------------------------------------------------------------ to keep timestamps on installed files. This method usually works for Makefiles generated by recent autotools. * Documents ! This software is actually under GPLv2 (from the source codes), however "COPYING" file is GPLv3 text. - "ABOUT-NLS" is not useful for this package because this (usually) shows general information for transformation. * Desktop files - Usually desktop files should be installed under %_datadir/applications. Would you check if %_datadir/vcards-evo-daemon is the desired directory for desktop files to be installed for this package? ping? ping again? I will close this bug if no response is received from the reporter within ONE WEEK. Well, it's been well over a week, so I'll go ahead and close this. |