Bug 472792
| Summary: | Review Request: jempbox - A Java library that implements Adobe's XMP specification | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mary Ellen Foster <mefoster> | ||||
| Component: | Package Review | Assignee: | Conrad Meyer <cse.cem+redhatbugz> | ||||
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | cse.cem+redhatbugz, fedora-package-review, mycae, notting, orion, tcallawa | ||||
| Target Milestone: | --- | Flags: | cse.cem+redhatbugz:
fedora-review?
|
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2009-10-08 14:45:18 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Mary Ellen Foster
2008-11-24 17:16:21 UTC
Updated with a better BuildRoot and with dist in the version: http://mef.fedorapeople.org/packages/java-libraries/jempbox.spec http://mef.fedorapeople.org/packages/java-libraries/jempbox-0.2.0-3.fc10.src.rpm Created attachment 327246 [details]
[Review]
Attached is my initial review. Thanks for submitting this software to Fedora!
General comments:
- Why the %update_maven_depmap and friends? It uses ant to build, not maven (note: I don't think this is wrong necessarily, I'm just unfamiliar with maven and would like to understand if this should be part of the java packaging guidelines for ant-built packages as well as maven).
Will approve as soon as "BAD" marked thing is either fixed or explained.
XMP is adobe's new proprietary format that implements metadata in files, kinda like exif, but supposedly somehow better. It is a patented "technology", however Adobe have provided a "public patent licence" http://www.adobe.com/devnet/xmp/pdfs/xmp_public_patent_license.pdf It seems OK to me, but IANAL -- are there any legal issues to consider? The clause "A claim is necessarily infringed only when there is no reasonable way to avoid infringement of that claim when defining, creating or processing metadata." seems a bit nebulous. We should have RH Legal look at it just in case. Blocking FE-Legal for now. Everything checks out here. Lifting FE-Legal. I'm working on packaging up jempbox 0.8.0 from Apache Incubating: http://incubator.apache.org/pdfbox/ Are you still wanting to proceed with this review or shall I close and submit my own? (In reply to comment #6) > I'm working on packaging up jempbox 0.8.0 from Apache Incubating: > > http://incubator.apache.org/pdfbox/ > > Are you still wanting to proceed with this review or shall I close and submit > my own? You can go ahead and submit your package -- sorry I let this sit for so long. :( *** This bug has been marked as a duplicate of bug 527996 *** |