Bug 472794

Summary:	Review Request: onemind-commons-java - A common library used to support other onemind libraries
Product:	[Fedora] Fedora	Reporter:	Mary Ellen Foster <mefoster>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED DEFERRED	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, mycae, notting
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-01-29 10:14:57 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Mary Ellen Foster 2008-11-24 17:19:00 UTC

Spec URL: http://mef.fedorapeople.org/packages/java-libraries/onemind-commons-java.spec
SRPM URL: http://mef.fedorapeople.org/packages/java-libraries/onemind-commons-java-1.5.5-2.src.rpm

Description:
This is a common library used to support other onemind libraries.

(Upstream seems sort of dormant, but this is an indirect dependency of some other Java packages ...)

Comment 1 Mary Ellen Foster 2008-12-09 16:37:26 UTC

Changed buildroot, added dist to version:

http://mef.fedorapeople.org/packages/java-libraries/onemind-commons-java.spec
http://mef.fedorapeople.org/packages/java-libraries/onemind-commons-java-1.5.5-3.fc10.src.rpm

Comment 2 D Haley 2008-12-28 13:04:02 UTC

Please excuse any really dumb questions, I am somewhat new at this process myself.


Not a formal review:

>$RPM_BUILD_ROOT
Is there a preference for %{buildroot} for newer packages?

># This was obtained on 2008/11/24 using the following commands:
>#   cvs -d :pserver:anonymous.sourceforge.net:/cvsroot/onemind-commons login
>#   cvs -d :pserver:anonymous.sourceforge.net:/cvsroot/onemind-commons co commons-java/docs
>Source1:        %{name}-docs-20081124.tbz

Can you check out a particular CVS version, rather than HEAD -- that way the md5sum can be verified as being consistent during review. I know the upstream is dormant, so this is probably a bit picky.

>BuildRoot:      %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
I am unclear -- what is the reason for changing the BuildRoot? ("Fix BuildRoot to follow the latest guidelines") Can you point to a page (in your reply) for the less up-to-date of us?

>%description
>This is a common library used to support other onemind libraries.

Is it possible to expand on this at all? Its identical to the summary -- doesn't really provide extra information to users. That said, I am not sure what one would write here as an alternative.


>%{_javadir}/*.jar

I think I would prefer %{name}.jar and {name}-%{version}.jar to be explicit. This prevents any later inadvertant jar copying (another picky comment.)


Other than that, it seems OK to me. There are no jars, licence seems OK and GPL header present in all java files.

Comment 3 D Haley 2008-12-28 13:32:48 UTC

Oh, and you are missing the deps in the -javadoc package.

Comment 4 Mary Ellen Foster 2009-01-29 10:14:57 UTC

I'm withdrawing this review for the moment because it's no longer a requirement for the packages I'm currently working on.