Bug 472960
Summary: | rg_test script does not provide adequate debugging of a faulty cluster.conf | ||
---|---|---|---|
Product: | [Retired] Red Hat Cluster Suite | Reporter: | Stuart R. Kirk <Stuart.Kirk> |
Component: | rgmanager | Assignee: | Lon Hohberger <lhh> |
Status: | CLOSED WONTFIX | QA Contact: | Cluster QE <mspqa-list> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 4 | CC: | cluster-maint, edamato, toddw |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2010-01-21 19:38:30 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Attachments: |
Description
Stuart R. Kirk
2008-11-25 20:14:00 UTC
Created attachment 324659 [details]
Introducing a typo and subsequent display of expected output.
I would expect that when a typo is introduced (intentionally or otherwise) to a cluster configuration that the rg_test script will alert the user to the problem that is found. That is the case in this example.
Created attachment 324661 [details]
Introducing several typos which are not found by rg_test
I would expect that rg_test would alert the user to the misspelling of "ref" in the cluster configuration, however it doesn't seem to be as thorough as it should be in checking the XML syntax.
"Valid" and "correct" are very different. Typos don't necessarily make a cluster.conf invalid, but they can make them semantically wrong. In this particular case, sometimes, it's not what's written, but what isn't. The service structure's output is flat-out *wrong* if you add the typo. If it would make more sense, the XML outputs would have been like this: <service name="test" autostart="1" hardrecovery="0" exclusive="0" nfslock="0" recovery="restart" depend_mode="hard" max_restarts="0" restart_expire_time="0"> <lvm name="armstrong2-oracle-vol" vg_name="armstrong2vg" lv_name="oracle" nfslock="0" /> <fs name="armstrong2-oracle-fs" mountpoint="/armstrong2/oracle" device="/dev/mapper/armstrong2vg-oracle" fstype="ext3" force_unmount= "1" self_fence="1" nfslock="0" fsid="47123" force_fsck="0" /> <ip address="40.1.255.23" monitor_link="1" nfslock="0" /> </service> With the typo added... <service name="test" autostart="1" hardrecovery="0" exclusive="0" nfslock="0" recovery="restart" depend_mode="hard" max_restarts="0" restart_expire_time="0" /> We can detect some things easily (say wrong "reff"). This is actually fairly easy to add, and I agree that it should be added. However, reporting errors for unrecognized attributes names is more difficult and probably will get us into trouble: we obsolete attribute names from time to time, but this doesn't make the configuration invalid (or even incorrect!). Because the names of attributes and such are from the resource agents' metadata, and are not something that rg_test is aware of at compile-time (only run-time), maintaining a list of "obsolete" attributes within rg_test is just begging for problems. We are working on updating the cluster.conf schema to be more robust. Development Management has reviewed and declined this request. You may appeal this decision by reopening this request. |