Bug 473363
Summary: | system-config-network crashes when i set MTU | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ramsey Haddad <ramsey.haddad> |
Component: | system-config-network | Assignee: | Harald Hoyer <harald> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 10 | CC: | gordon.messmer, harald, jfaith, jmoskovc, jon.dufresne, netllama |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | i386 | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-02-17 17:56:58 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Ramsey Haddad
2008-11-28 00:42:26 UTC
Same problem here. Problem here is that ConfShellVar __setitem__ it not able to cope with variables that have a numeric value. /usr/share/system-config-network/netconfpkg/conf/ConfShellVar.py Adding the following as line 53 fixes the problem by forcing value to be a string value='%s'%(value) #ensure value is a string output from diff -c *** orig 2008-11-28 10:57:59.000000000 +0000 --- ConfShellVar.py 2008-11-28 11:01:32.000000000 +0000 *************** *** 50,55 **** --- 50,56 ---- # prevent tracebacks if not value: value = "" + value='%s'%(value) #ensure value is a string # set *every* instance of varname to value to avoid surprises place = self.tell() self.rewind() Hi, I just checked to see if this issue has been fixed. In updates for Fedora 10 there is system-config-network-tui-1.5.95-1.fc10.noarch.rpm which seems to work fine. The fix seems to be to be in system-config-network/netconfpkg/NCDevice.py @@ -409,8 +411,8 @@ for selfkey in self.__intkeydict.keys(): confkey = self.__intkeydict[selfkey] - if hasattr(self, selfkey): - conf[confkey] = getattr(self, selfkey) + if hasattr(self, selfkey) and getattr(self, selfkey) != None: + conf[confkey] = str(getattr(self, selfkey)) else: del conf[confkey] It is the str() function call that fixes the problem by ensuring the value is a string, in a similar way to my '%s'%(value) patch. So I think this issue can be closed as it has already been fixed by someone. Thank you for the bug report. This particular bug was fixed and an updated package was published for download. If you find that the bug still persists feel free to reopen this bug. You can obtain the updated package by typing 'yum update <package>' or using the graphical updater, Software Update. |