Bug 473413

Summary: Review Request: system-config-samba-docs - Documentation for configuring a Samba server
Product: [Fedora] Fedora Reporter: Nils Philippsen <nphilipp>
Component: Package ReviewAssignee: Jason Tibbitts <j>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting
Target Milestone: ---Flags: j: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-01-14 13:26:58 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Nils Philippsen 2008-11-28 12:08:58 UTC
Spec URL: http://nphilipp.fedorapeople.org/review/system-config-samba-docs.spec
SRPM URL: http://nphilipp.fedorapeople.org/review/system-config-samba-docs-1.0.1-1.fc10.src.rpm
Description: This package contains the online documentation for system-config-samba which is a graphical user interface for creating, modifying, and deleting samba shares.

Comment 1 Nils Philippsen 2008-12-08 18:38:08 UTC
NB: The package can only be installed with the related tool (with the same documentation stripped) which I plan to release together with this package (once the review is finished).

I've uploaded new files with some fixes at:
Spec: http://nphilipp.fedorapeople.org/review/system-config-samba-docs.spec
SRPM: http://nphilipp.fedorapeople.org/review/system-config-samba-docs-1.0.2-1.fc10.src.rpm

Comment 4 Jason Tibbitts 2008-12-19 18:39:34 UTC
This is essentially identical to the other system-config-*-docs packages, so I'll be brief.  rpmlint:
  system-config-samba-docs.noarch: W: obsolete-not-provided system-config-samba
not a problem.

* source files match upstream.  sha256sum:
  00c7bc20f0734286a5ab16392fa5bd7072aeb2f75ec8239c75e31cdecc1aaf33  
   system-config-samba-docs-1.0.4.tar.bz2
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* rpmlint has acceptable complaints.
* final provides and requires are sane.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* scriptlets are OK.
* acceptable content

APPROVED

All done!

Comment 5 Nils Philippsen 2008-12-19 22:36:04 UTC
Thanks for reviewing!

New Package CVS Request
=======================
Package Name: system-config-samba-docs
Short Description: Documentation for configuring a Samba server
Owners: nphilipp
Branches: F-9 F-10

Comment 6 Kevin Fenzi 2008-12-21 04:39:56 UTC
cvs done.