Bug 473486

Summary: unchecked return values in sysklogd
Product: [Fedora] Fedora Reporter: mpachary
Component: sysklogdAssignee: Jeroen van Meeuwen <vanmeeuwen+fedora>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: vanmeeuwen+fedora
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-12-02 00:29:06 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description mpachary 2008-11-28 20:02:15 UTC
Description of problem:
unchecked return values in sysklogd

Version-Release number of selected component (if applicable):

sysklogd-1.3.31-3

How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

here is the list

 ./sysklogd-1.3-31/syslogd.c:2268:		*nextp = (struct filed *)calloc(1, sizeof(*f)); ### return value of calloc, *netxtp, passed to cfline without checking 
 ./sysklogd-1.3-31/syslogd.c:2270:		(*nextp)->f_next = (struct filed *)calloc(1, sizeof(*f))	/* ASP */ ### return value of calloc, (*nextp)->f_next passed to cfline without checking 
 ./sysklogd-1.3-31/syslogd.c:2312:		f = (struct filed *)calloc(1, sizeof(*f)); ### return value of calloc, f, is assigned to *nextp and later dereferenced in line 2314 
 
 ./sysklogd-1.3-31/klogd.c:912:	chdir ("/"); ### return value of chdir not checked 
 ./sysklogd-1.3-31/syslogd.c:793:	chdir ("/"); ### return value of chdir not checked

Comment 1 Jeroen van Meeuwen 2008-12-02 00:29:06 UTC
This version is not supported in any current Fedora release (Fedora 8, 9 or 10). Please make sure you have selected the correct product, and you have provided the correct output of rpm -qv sysklogd.